Skip to content

[WIP] Mixed precision (32-bit main) for dynamics & GEOS 11.4.2 feature set#63

Draft
FlorianDeconinck wants to merge 396 commits into
developfrom
develop__GEOSv_11_4_2
Draft

[WIP] Mixed precision (32-bit main) for dynamics & GEOS 11.4.2 feature set#63
FlorianDeconinck wants to merge 396 commits into
developfrom
develop__GEOSv_11_4_2

Conversation

@FlorianDeconinck
Copy link
Copy Markdown
Collaborator

@FlorianDeconinck FlorianDeconinck commented Jun 26, 2025

This is the full suite of changes to bring the dynamics to a 32-bit first (but implemented mixed) capabilities. It also brings non reconcilable changes to Remapping that where implemented in GEOS.

The entire codebase was ported from GEOS 11.4.2

FlorianDeconinck and others added 30 commits January 20, 2025 11:56
@FlorianDeconinck
Move dpx to be passed in the acoustics instead of temp
21f4d34
@FlorianDeconinck
dpx calculated on cell center
036fc2f
@FlorianDeconinck
Merge branch 'GEOS_update/yppm_xppm' into develop__GEOSv_11_4_2
89e9e07
@FlorianDeconinck
Merge branch 'fix/GEOS/D_SW' into develop__GEOSv_11_4_2
66ced6d
@FlorianDeconinck
Merge branch 'fix/GEOSv11_4_2/DynCore' into develop__GEOSv_11_4_2
7ae236d
@FlorianDeconinck
Add remapping reference to README
6d28e5b
@FlorianDeconinck
Lint
b3c7941
@FlorianDeconinck
Remapping GEOS obejct (untested)
6c8b424
@FlorianDeconinck
Update dynamics with custom Remapping
e90d0e7
@FlorianDeconinck
Typo
c39a2a4
@gmao-ckung
Accounting for j=je+1 calculations in map u
0d749d2
@gmao-ckung
Corrected issue that caused pt to incorrected read netCDF file
d23f391
@gmao-ckung
Continued verifying GEOS remapping/fv_mapz
3953b29
@gmao-ckung
Adding fv_mapz serialization file
5567bc9
@gmao-ckung
Removed extraneous variables from GEOS remapping translate test and a…
a53c3fe 
…dded fill condensate stencil to translate test
@gmao-ckung
Added fv_mapz serialization file
e61b6bb
@gmao-ckung
Small correction in mpp_global_sum.py
6c13879
@FlorianDeconinck
remapper: align with modified dynamics
8e59317 
`moist_cv`: lint
@FlorianDeconinck
Revert "Update dynamics with custom Remapping"
2a774ac 
This reverts commit e90d0e7.
@FlorianDeconinck
Revert "Typo"
2645e4f 
This reverts commit c39a2a4.
@FlorianDeconinck
Merge branch 'feature/fv_mapz_GEOS' into develop__GEOSv_11_4_2
242ccb8
@FlorianDeconinck
Fluxes and courant number as independent parameters (out of state)
9934749
@FlorianDeconinck
Update translate test to independent fluxes/courant
e3b799b
@FlorianDeconinck
Add compute total energy function (partial)
754bc14
@FlorianDeconinck
Fluxes & Courant number are local then increment global fields (f32)
e4acb47 
Add DryMassRoudnOff code (f32)
Compute total energy in preamble
GEOS Lagrangian code
@FlorianDeconinck
Adapt translate test & allow for ULP<100 to pass test
12cdd70
@FlorianDeconinck
Merge branch 'fix/GEOSv11_4_2/DynCore' into develop__GEOSv_11_4_2
49f68f1
@FlorianDeconinck
Merge branch 'fix/GEOSv11_4_2/Dynamics' into develop__GEOSv_11_4_2
013c7c4
@FlorianDeconinck
Remove checkpointers
968a535
@FlorianDeconinck
Merge branch 'fix/GEOSv11_4_2/Dynamics' into develop__GEOSv_11_4_2
c920cdb
@FlorianDeconinck
Tracer2D1L: restore code ate by merge
f05f253
@FlorianDeconinck
Verbose TracerCMax callback issue w/ ticket
133fe71
@FlorianDeconinck
Update to develop NDSL
49dbd82
@FlorianDeconinck
FVDynamics orchestration
06a4209
@FlorianDeconinck
Fix tracers marshalling in translate_RemappingGEOS
53a3dba
@FlorianDeconinck
Move NDSLRuntime across Acoustics codes
f816cb3
@FlorianDeconinck
Condig: pass dz_min down from a namelist read
90cfc42 
Initialize the all of `zs` with `phis`, including halos, as does the Fortran
@FlorianDeconinck
Move threshold of 100 ULP for all backends on FV
b7db557
@FlorianDeconinck
Mixed precision for the Configuration
b12419c
@FlorianDeconinck
NDSRuntime the XPPM & YPPM
613190d
@FlorianDeconinck
Bad merge brought a dual application of the pt to potential densit…
a782a72 
…y `pt`
@FlorianDeconinck
Use da_min and da_min_c directly
00b4e6d
@FlorianDeconinck
Lint
d9d3449
@FlorianDeconinck
Remove archived old fv_mapz
dfa2277
@FlorianDeconinck
Implementing nwat==0
44e969f
@FlorianDeconinck
Move timing collection into it's own file to calm down mypy
ca8c149
@FlorianDeconinck
Align xppm and yppm
3fc78a3
@FlorianDeconinck
Align xppm & yppm again
a96b7e0
@FlorianDeconinck
Upgrade all to NDSLRuntime
ec20c54
@FlorianDeconinck
To locals: D_SW
c05fca2
@FlorianDeconinck
To locals: DynCore
258dcb1
@FlorianDeconinck
To locals: Remapping_GEOS + Validation thresholds
22d8589
@FlorianDeconinck
To locals: Tracer2D1L
8595d72
@FlorianDeconinck
Refactor unused local or local that can be inlined in stencils as tem…
8a399a7 
…poraries
@FlorianDeconinck
To Locals: FVDynamics
a180141 
- pass `wsd` directly in Acoustics instead of a weird init level cache
- one unexplianed failure to go Local with `te0_2d`
@FlorianDeconinck
Remove dead code + lint on Tracers
65543bb
@FlorianDeconinck
Workaround in copy corners for SDFG -> STree bug
19cff26
@FlorianDeconinck
Guard for nwat<6
289f55a
@FlorianDeconinck
Fix type of Tracers in compute total energy
dba4907
@FlorianDeconinck
Restore temparay fields in tracer adjustement code
b3a2ef1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oelbert oelbert Awaiting requested review from oelbert

@bensonr bensonr Awaiting requested review from bensonr

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@FlorianDeconinck @gmao-ckung @CharlesKrop