Skip to content

[WIP] Update lat and lon variable names in cmor_mixer and cmor_helper#152

Draft
Copilot wants to merge 2 commits into
mainfrom
copilot/update-lat-lon-variable-names
Draft

[WIP] Update lat and lon variable names in cmor_mixer and cmor_helper#152
Copilot wants to merge 2 commits into
mainfrom
copilot/update-lat-lon-variable-names

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 14, 2026

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.


This section details on the original issue you should resolve

<issue_title>critical bits of feedback from @zappalaja</issue_title>
<issue_description>> - Made small changes to cmor_mixer py and cmor_helper py to allow 'lat' and 'lon' variable names instead of 'latitude' and 'longitude' and to allow ‘cartesian_axis’ as an axis option.

Originally written by @zappalaja elsewhere

this should be more than doable</issue_description>

Comments on the Issue (you are @copilot in this section)

@ilaflott crucial bit 1: https://github.com/NOAA-GFDL/fre-cli/commit/9b7e0c0bbd60e42480d5599c838c64518f004870

crucial bit 2: NOAA-GFDL/fre-cli@f0eaa9a</comment_new>

Copilot AI linked an issue May 14, 2026 that may be closed by this pull request
Copilot AI requested a review from ilaflott May 14, 2026 00:57
Copilot stopped work on behalf of ilaflott due to an error May 14, 2026 01:03
@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.83%. Comparing base (2f6d320) to head (09b6c76).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #152   +/-   ##
=======================================
  Coverage   94.83%   94.83%           
=======================================
  Files          11       11           
  Lines        1336     1336           
=======================================
  Hits         1267     1267           
  Misses         69       69           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f6d320...09b6c76. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

critical bits of feedback from @zappalaja

2 participants