Add refinediag preanalysis tests#229
Conversation
…ows into 216.refinediag-preanalysis-tests
216.refinediag preanalysis tests
| # to have a faster turn-around (does not test archive data staging), use the below | ||
| history_dir: "/work/inl/test_cloud_runner_history_files" | ||
| history_dir: "/work/inl/test_cloud_runner_history_files" | ||
| refined_history_dir: "/work/d4s/fre-wf-local-testing/refined_history" |
There was a problem hiding this comment.
How about /work/$USER/... instead so it will work for everyone?
There was a problem hiding this comment.
OH, good catch! I meant to change this
There was a problem hiding this comment.
Chris....you may have just really helped the problem I've had for like 2 weeks with this catch. (at least for the local test). I didn't realize the refineDiag post-script was looking somewhere else (with $USER) for files.
There was a problem hiding this comment.
Wait...uhg, nevermind, I see my same issue again. It seems when I update the refine_history path to something new, the refineDIag post-script works. However, if I don't update the path and run again, it does not somehow. Continuing to look into
…ows into 216.refinediag-preanalysis-tests
…hub.com:singhd789/fre-workflows into 216.refinediag-preanalysis-tests
- uhg - we were cleaning the experiment but not this output folder which lead to a known issue with hsmget (can't have folders wrapped in a tar file)
| # this might be better in the DOckerfile? | ||
| #print the line to make sure it was changed in the build | ||
| sed -n '28p' /app/cylc-flow-tools/mk/hsmput.mk | ||
|
|
There was a problem hiding this comment.
Lying in bed last night, I thought that I should have suggested removing hsmget and hsmput entirely at the first glimpse that they were non-portable, and replaced them with humble tars.
But.. since we're this far, can we use hsm/1.4.0 instead of this sed?
There was a problem hiding this comment.
Yeah, luckily this line I think is only checking that that line was changed with the -n option - so it's not actually changing anything here. I can remove this line.
Now, unfortunately, in order to use the hsm1.4.0 package, I had to update the cylc-flow-tools.yaml , which meant the container needed to be rebuilt.....but when I built it again is when I realized fregrid was not available anymore 😢
ceblanton
left a comment
There was a problem hiding this comment.
Except for the ppan.cylc test changes, this is more than ready.
How are we going to get fre-nctools back into the cloud pipeline?
ceblanton
left a comment
There was a problem hiding this comment.
It looks perfect. Thank you so much for the this, which turned out to be so much harder than I could have imagined.
I just don't know how it was working before 😆 |
…hub.com:singhd789/fre-workflows into 216.refinediag-preanalysis-tests
Describe your changes
Issue ticket number and link (if applicable)
Fixes #216
Checklist before requesting a review
Manual Pipeline Run Details
Was the manual pipeline (
test_cloud_runner) triggered for this PR?Yes
No
Manual pipeline was run but changes made in pipeline not seen until merged in (I don't think)
pipeline results show preanalysis and refinediag scripts run BUT there is a
mask-atmos-plevel_atmos_month_cmiperror 😢 (for workflow artifact files: https://github.com/NOAA-GFDL/fre-workflows/actions/runs/25129758975/job/73656944006)(Paste relevant logs, output, or a link to the workflow run here)
How to trigger the manual pipeline:
The
test_cloud_runnerpipeline is not automatically associated as a required check with the PR; it must be triggered to test changes in a full post-processing run.To trigger the manual pipeline:
Follow the link to the
test_cloud_runneractions tab hereClick the dropdown "Run workflow":
a. If trying to merge from a branch on fre-workflows: choose branch from the first drop down, leave the next 2 inputs blank, and choose the fre-cli branch to test
b. If trying to merge from a fre-workflows fork: can skip first branch selection, input the fork name (ex: [user]/fre-workflows), input the fork's branch name, and choose the fre-cli branch to test
Click "Run workflow"
Note: you may need to reload the page to see your running workflow.