Skip to content

Add fill flag #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Ciheim wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −1
Draft

Add fill flag #893

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
773e580
add fill flag
May 14, 2026
52d3551
Merge branch 'main' into 892.catalogfill
ceblanton May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion fre/catalog/frecatalog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ def catalog_cli():
#, help = 'Specify output filename suffix only. e.g. catalog')
@click.option('--config', required = False, type = click.Path(exists = True), nargs = 1,
help = 'Path to your yaml config, Use the config_template in intakebuilder repo')
@click.option('--fill', '-f', default=True, type=bool, help="Fill all empty CSV column values with 'NA'. Defaults to True. Use --fill=False to disable.")
Copy link
Copy Markdown
Contributor

@ceblanton ceblanton May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To negate the fill option, it's more standard to make it a flag and let it be negated with --no-fill than require an value for the fill option --fill=False.

@click.option('--filter_realm', nargs = 1)
@click.option('--filter_freq', nargs = 1)
@click.option('--filter_chunk', nargs = 1)
Expand All @@ -34,7 +35,7 @@ def catalog_cli():
@click.option('--strict', is_flag = True, default = False,
help = "Ensure output catalog is strictly compliant with schema")
@click.pass_context
def build(context, input_path = None, output_path = None, config = None, filter_realm = None,
def build(context, input_path = None, output_path = None, config = None, fill = True, filter_realm = None,
filter_freq = None, filter_chunk = None, verbose = False, overwrite = False,
append = False, slow = False, strict = False):
# pylint: disable=unused-argument
Expand Down
Loading