fix remapping to enable compilation on flang and amdflang - #1076
Closed
JorgeG94 wants to merge 2 commits into
Closed
fix remapping to enable compilation on flang and amdflang#1076JorgeG94 wants to merge 2 commits into
JorgeG94 wants to merge 2 commits into
Conversation
|
There happens to be a pending PR from the main repo exactly on this issue. mom-ocean#1692 |
Author
Oh cool. Should that be done there or here? I can close this |
Author
I ran the tests locally and they passed! |
Member
|
I am closing this PR because it deals with an issue that has already been addressed by mom-ocean#1692, which is now on the dev/gfdl branch of MOM6. |
Author
|
thanks! great to see |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A very simple fix to enable MOM6 to compile using
flangknown before asflang-new. This enables also MOM6 to be compiled withamdflangwhich will be our way to AMD GPUs. The fix is simple,flangdoes not like a type being called the same way as the variable, so I just added_.