Fix mpp_gather/scatter memory leak#1892
Draft
abrooks1085 wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes Valgrind-reported memory errors in the MPP gather/scatter paths.
The issue was caused by passing either an unassociated pointer array or an unallocated allocatable array as an actual argument to a subroutine whose corresponding dummy argument is an assumed-shape intent(in) array. In these cases, the call is invalid because the assumed-shape dummy requires a valid array descriptor from the actual argument. Even when the data is only logically used on the root rank, forwarding an invalid array argument on another rank can still expose undefined descriptor state and trigger memory diagnostics.
This PR updates the affected gather/scatter wrapper paths so that all ranks pass valid array arguments into the lower-level routines. For ranks that do not logically contribute or consume the full root-side buffer, a valid temporary array/view is used instead of forwarding an unassociated pointer or unallocated allocatable.
Fixes #1890
How Has This Been Tested?
Checklist:
make distcheckpasses