Skip to content

diag_manager: reword error message to make it more useful#1888

Open
uramirez8707 wants to merge 2 commits into
NOAA-GFDL:mainfrom
uramirez8707:correct_error_message
Open

diag_manager: reword error message to make it more useful#1888
uramirez8707 wants to merge 2 commits into
NOAA-GFDL:mainfrom
uramirez8707:correct_error_message

Conversation

@uramirez8707

Copy link
Copy Markdown
Contributor

Description
reword error message to make it more useful

Fixes # (issue)

How Has This Been Tested?
ci

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

Comment thread diag_manager/fms_diag_file_object.F90 Outdated
call mpp_error(FATAL, "The axis for the variable:"//trim(field_yaml%get_var_varname())//&
"in the file: "//trim(this%get_file_fname())//" are not the same as the previously "//&
"defined variables. If using the cube sphere and defining the subregion with latlon "//&
"all variables in the file need to have the same x and y axis.")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it the same x & y axis or the same dimension lengths for the x & y axis?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has to be the same x and y axis.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this what you mean? "Axes for variable {variable} in file {file} differ from the axes for the other variables in file {file}. All variables in a file need to be registered with the same axes"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mlee03 captured what I was trying to say. The difference between axis as a coordinate and axes as a proxy for the dimensions used is significant and should be better emphasized in the documentation.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the updated message, but wanted to know if this applies only to subregional files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants