Skip to content

Add corner mosaic tests to mpp suite#1868

Merged
vithikashah001 merged 10 commits into
NOAA-GFDL:mainfrom
vithikashah001:test_corner_mosaic
May 27, 2026
Merged

Add corner mosaic tests to mpp suite#1868
vithikashah001 merged 10 commits into
NOAA-GFDL:mainfrom
vithikashah001:test_corner_mosaic

Conversation

@vithikashah001

@vithikashah001 vithikashah001 commented May 6, 2026

Copy link
Copy Markdown
Contributor

Description
the code integrates existing corner mosaic tests into the mpp unit test suite

Fixes # (issue)

How Has This Been Tested?
with autotools on amd box

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

Comment thread test_fms/mpp/test_corner_mosaic.F90
Comment thread test_fms/mpp/test_corner_mosaic.F90 Outdated
! Corner mosaic layout:
! - Tile 1: 4x4
! - Tile 2: 6x4
! - Tile 3: 4x6

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the values below have been changed, this comment should either be updated or deleted.

Comment thread test_fms/mpp/test_corner_mosaic.F90 Outdated
! ----- !
! |1|2| !
! ----- !
!!!!!!!!!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the best place for this figure would probably be in a description at the top of the file.

Comment thread test_fms/mpp/test_corner_mosaic.F90 Outdated
! ----- !
! |1|2| !
! ----- !
!!!!!!!!!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above regarding this figure.

@J-Lentz

J-Lentz commented May 15, 2026

Copy link
Copy Markdown
Contributor

Thanks Vithika!

@vithikashah001 vithikashah001 requested a review from J-Lentz May 18, 2026 16:07

@rem1776 rem1776 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vithikashah001 vithikashah001 merged commit 0b0d48a into NOAA-GFDL:main May 27, 2026
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants