Skip to content

General Indices: Diag Manager Test#1833

Merged
vithikashah001 merged 23 commits into
NOAA-GFDL:mainfrom
abrooks1085:feature/general-indices-diag-manager-tests
Jun 11, 2026
Merged

General Indices: Diag Manager Test#1833
vithikashah001 merged 23 commits into
NOAA-GFDL:mainfrom
abrooks1085:feature/general-indices-diag-manager-tests

Conversation

@abrooks1085

@abrooks1085 abrooks1085 commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

Description
Adds test coverage for generalized axis permutations in the diag_manager.

Recent support for generalized indices requires validation that axis metadata (dimension ordering) and data layout remain consistent through send_data and I/O. These tests validate that axis registration (metadata) and data permutation remain consistent with canonical data through the write/read path.

The tests use structured data encoding to reliably detect index/order mismatches and exercise multiple permutations, including swaps and cyclic permutations (e.g., YX, ZYX, YZX, ZXY). Tests are performed in a local (non-decomposed) configuration, isolating permutation correctness from domain decomposition and masking effects.

How Has This Been Tested?
amdbox + intel + autotools

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@uramirez8707 uramirez8707 requested a review from J-Lentz March 31, 2026 17:13
@abrooks1085 abrooks1085 changed the title Add diag manager test to register var with different axes permutations Add diag manager test to register var with different axis permutations Apr 24, 2026
@uramirez8707

Copy link
Copy Markdown
Contributor

@abrooks1085, can you check if removing the "contiguous" keyword out of diag_send_data resolves the CI failures.
uramirez8707@295ef82

Comment thread test_fms/diag_manager/Makefile.am Outdated
Comment thread test_fms/diag_manager/test_time_none.sh
@abrooks1085 abrooks1085 marked this pull request as ready for review June 11, 2026 02:44
@abrooks1085 abrooks1085 changed the title Add diag manager test to register var with different axis permutations General Indices: Diag Manager Test Jun 11, 2026
@vithikashah001 vithikashah001 merged commit 4e85c7e into NOAA-GFDL:main Jun 11, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants