Skip to content

horiz_interp fixes for r4 tests#1736

Merged
vithikashah001 merged 5 commits into
NOAA-GFDL:mainfrom
rem1776:horiz_interp_r4_fixes
Jul 29, 2025
Merged

horiz_interp fixes for r4 tests#1736
vithikashah001 merged 5 commits into
NOAA-GFDL:mainfrom
rem1776:horiz_interp_r4_fixes

Conversation

@rem1776

@rem1776 rem1776 commented Jul 16, 2025

Copy link
Copy Markdown
Contributor

Description
Fixes the r4 tests to build properly (see issue below) and makes some adjustments in the code for when using kind 4 reals. Tolerances needed to be a bit large for the bicubic test in particular, not sure if thats just due to the algorithm.

Fixes #1735

How Has This Been Tested?
make distcheck on amd box

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

Comment thread test_fms/horiz_interp/test_horiz_interp.F90
@vithikashah001 vithikashah001 merged commit 71fa3a0 into NOAA-GFDL:main Jul 29, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

horiz_interp mixed precision issues

3 participants