fms2_io: Add generalized indices test#1734
Merged
Merged
Conversation
Add a test to ensure that fms2_io is able to write and read back a domain-decomposed array where the `x` and `y` dimensions correspond to arbitrary permutations of the array's first three indices.
uramirez8707
approved these changes
Jul 15, 2025
uramirez8707
left a comment
Contributor
There was a problem hiding this comment.
Thank you for this update! This will very helpful as we make changes to fms2io (i.e the mpp_gather updates)!
rem1776
approved these changes
Jul 16, 2025
vithikashah001
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a test to ensure that fms2_io is able to write and read back a domain-decomposed array where the
xandydimensions correspond to arbitrary permutations of the array's first three indices.How Has This Been Tested?
Test builds and passes on C5 using intel-classic/2023.2.0.
Checklist:
make distcheckpasses