Skip to content

FMS_IO: Deprecate fms_io/mpp_io#1669

Merged
rem1776 merged 5 commits into
NOAA-GFDL:mainfrom
uramirez8707:end_of_an_era
May 14, 2025
Merged

FMS_IO: Deprecate fms_io/mpp_io#1669
rem1776 merged 5 commits into
NOAA-GFDL:mainfrom
uramirez8707:end_of_an_era

Conversation

@uramirez8707

@uramirez8707 uramirez8707 commented Mar 25, 2025

Copy link
Copy Markdown
Contributor

Description

  • Removes fms_io/mpp_io and all its deprecated code
  • Removes the workflows that test the use_deprecated_io code option
  • If someone attempts to use the use_deprecated_io code with autotools and cmake, they will get an error

Fixes #1669 #1270

How Has This Been Tested?
CI

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@uramirez8707 uramirez8707 added this to the 2023.03 milestone Mar 25, 2025
@uramirez8707 uramirez8707 self-assigned this Mar 27, 2025
@uramirez8707 uramirez8707 marked this pull request as ready for review April 28, 2025 17:59
rem1776
rem1776 previously approved these changes May 9, 2025

@rem1776 rem1776 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just had a minor comment on the error message, everything else LGTM

Comment thread CMakeLists.txt Outdated
Comment thread CMakeLists.txt Outdated
Comment thread configure.ac
Comment thread CMakeLists.txt Outdated
Comment thread configure.ac
@rem1776 rem1776 merged commit d970d8d into NOAA-GFDL:main May 14, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants