Update contribution templates and user guidance#194
Conversation
|
Link to ReadTheDocs sample build for this PR can be found at: |
|
Link to ReadTheDocs sample build for this PR can be found at: |
| - [ ] bug | ||
| - [ ] enhancement | ||
| - [ ] documentation | ||
| - [ ] configuration | ||
| - [ ] data | ||
| - [ ] training | ||
| - [ ] inference | ||
| - [ ] verification | ||
| - [ ] CI/CD |
There was a problem hiding this comment.
There seems to be significant overlap between this section and the Type of change and Area(s) affected sections above. Has the submitter potentially already provided this information via one of those two sections? Would it be possible to somehow combine these three sections?
|
Link to ReadTheDocs sample build for this PR can be found at: |
|
@AnilKumar-NOAA I'm sorry, I jumped into this PR too soon -- I see now that it's still marked Draft. I'll look again when you mark it Ready for review. |
@maddenp-cu please keep checking and review internally as a team. We have marked draft right now but keep working on it before we provide for review to Josh and Priya (US team) and get the documentation up to standards approval from them. |
|
Since there's a change to |
Yes, I agree. Since this PR now changes |
|
Link to ReadTheDocs sample build for this PR can be found at: |
|
The failure was later during model initialization: the |
|
@maddenp-cu The failure is different this time: CQC ran out of disk while building the hosted-runner environments, specifically while installing eagle-tools into the wxvx env. checking the existing filesystem-clean step to see whether we can free enough space before conda builds, or whether we should reduce what CQC builds. |
|
Link to ReadTheDocs sample build for this PR can be found at: |
Since when? This environment has been working correctly until today. What has changed?
But we want to use |
This happens every now and then, and usually (in my experience so far) succeeds if re-run, as the next runner usually has more space available. I re-ran the failed job and will keep an eye on it. The new job already says EDIT: The failed job started with and finished with So maybe 57 GB is not sufficient given our current environments, which have been updated several times since this CQC workflow was created. I'm also wondering whether we can minimize the disk usage of the job by disabling or aggressively cleaning the conda and pip caches for CI jobs. I'll look into it sometime soon. |
@maddenp-cu my PR is just documents update and I just saw this issue. I did some google search "the error message" "and also AI and just how to handle broken packages, and seems @DavidBurrows-NCO also facing this issue earlier- same error. Is this because of anemoi version change? |
@maddenp-cu I can revert the SDPA config change and instead focus on the real environment fix: pin or adjust the compatible |
|
Link to ReadTheDocs sample build for this PR can be found at: |
|
We have two proposed FAQs that we would like to add to the EAGLE User Guide prior to the capability announcement. Could we get someone to perform a technical review of the questions and answers below to ensure they are accurate before we move forward with publishing them? Could we get someone on the EAGLE team to take a look? @DavidBurrows-NCO, @maddenp-cu, @AnilKumar-NOAA Question 1: Proposed Answer: Question 2: Proposed Answer: @AnilKumar-NOAA , once the technical review is complete by your team, could you please add these FAQs to the User Guide under |
|
In |
|
A few suggestions for the nested_eagle.rst lines 79-81:
|
|
Please add the following terms to the glossary: AORC checkpoint CONUS ERA5 GEFS MET netCDF NRT PrepBUFR |
|
Link to ReadTheDocs sample build for this PR can be found at: |
@jdkublnick I don't know Anemoi well enough to weigh in on the correctness of Answer 1, but I have a couple of tangential comments:
@AnilKumar-NOAA I just noticed that we have two |
@AnilKumar-NOAA I think it might be because this note needs to be indented, and is breaking the auto-numbering because it is not. |
|
Link to ReadTheDocs sample build for this PR can be found at: |
@maddenp-cu Thanks, fixed the Quickstart numbering issue by indenting the note under step 1 and keeping the NRT label inside the list item. |
|
@AnilKumar-NOAA, please update FAQ 1, then I believe this PR will be ready to merge. Thank you! Question 1: Proposed Answer: Yes. Users can define multiple bounding boxes to specify subset regions (e.g., CONUS, Europe, etc.) by adding a focus_areas key to the PlotSample configuration block in the EAGLE pipeline base.yaml. This configuration generates plots that exclude the surrounding global domain. Although users can modify base.yaml directly for reference, it is recommended that they instead add the configuration to the eagle.yaml file created during Step 1.1.1 of the Quickstart Guide. Changes made directly to base.yaml may be overwritten during configuration composition, whereas updates made in eagle.yaml are preserved. For example, for the HRRR/CONUS domain, you may use |
|
Link to ReadTheDocs sample build for this PR can be found at: |
Description:
Updates repository contribution and support guidance.
Changes include:
Checks:
Type of change:
Area(s) affected
Commit Requirements:
Testing / Verification:
Commands/config used:
Evidence (logs, key output paths, screenshots if relevant):
Runtime Environment:
python --version:wxvx --version(if applicable):Commit Message:
Subcomponent Pull Requests: