Skip to content

Add Lambert Conformal Conic (LCC) Grid Utility - #91

Merged
bbakernoaa merged 2 commits into
mainfrom
aero/lcc-grid-utility-8331316290800441122
Apr 25, 2026
Merged

Add Lambert Conformal Conic (LCC) Grid Utility#91
bbakernoaa merged 2 commits into
mainfrom
aero/lcc-grid-utility-8331316290800441122

Conversation

@bbakernoaa

Copy link
Copy Markdown
Collaborator

I have implemented a new high-level utility create_lcc_grid in src/xregrid/utils.py to simplify the creation of Lambert Conformal Conic projection grids, which are widely used in regional meteorological modeling.

Key features:

  1. Aero Protocol Adherence: The function is backend-agnostic, supporting both eager NumPy execution and lazy Dask execution via the chunks parameter.
  2. Scientific Provenance: Automatically records the projection parameters and the compute backend (Eager/Lazy) in the dataset's history attribute.
  3. CF-Compliance: Generates standard-compliant coordinates, bounds, and CRS metadata.
  4. Robust Testing: Added a new test file tests/test_aero_grid_lcc.py that performs a "Double-Check" validation, ensuring identical numerical results between NumPy and Dask implementations and verifying laziness.

I have also verified that this change does not introduce regressions by running the full test suite (249 tests passed).


PR created automatically by Jules for task 8331316290800441122 started by @bbakernoaa

- Implement high-level Lambert Conformal Conic (LCC) grid creation in `utils.py`.
- Ensure backend-agnostic support (Eager/Lazy) with provenance tracking.
- Add comprehensive double-check tests for LCC grids.
- Address code review feedback regarding backend visibility in history.
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

- Implement high-level Lambert Conformal Conic (LCC) grid creation in `utils.py`.
- Ensure backend-agnostic support (Eager/Lazy) with provenance tracking.
- Add comprehensive double-check tests for LCC grids.
- Address code review feedback regarding backend visibility in history.
- Fix linting and formatting issues identified by CI.
@bbakernoaa
bbakernoaa merged commit a694572 into main Apr 25, 2026
3 checks passed
@bbakernoaa
bbakernoaa deleted the aero/lcc-grid-utility-8331316290800441122 branch April 25, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant