allow alarm to ring on first 6 hour interval always - #181
Open
DeniseWorthen wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
@dpsarmie Please let me know what testing might be required w/ the c1152 weekly test, if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is currently a bug in the output logging feature. While I believe it has no practicable impact, I am opening this PR for the v17 team leads to make a decision on whether to include it in the production branch. It does not impact logging of 1-hour output files and it does not impact logging of 6h output files, given how I understand the cycling. But this is not my area of expertise (cycling), so I defer to those who know more.
The logging feature relies on alarms to trigger the checking of the output files. It is controlled by the
toffsetvariable, which AlarmInit uses to align the starttime such that the rings will still be on our nominal 6 hour boundaries (ie, 0:6, 12:18) regardless of starting hour.The following shows the only conditions where I've determined that the current code fails:
The model's first advance begins at hour=21; MOM6 averaging starts 3 hours later; the first output file produce by MOM6 will be the "03" file, which is the hour=0:6 average on the following day.
The output logging relies on alarms ringing every 6 hours to tell it to check if the file is a) present and b) complete.
The bug is that the alarm does not actually ring at hour=24. However, since it is the alarms at hour=30 and 36 that are used in logging the 03 file, the fact that the alarm does not ring at hour=24 does not matter. All subsequent hour=00 alarms ring as expected. It is only the first ring that is silent.
Using the current toffset value and printing the alarm ring times shows (the two times are the curr time and the model advance time; alarms always ring on the advance time)
There is a missing alarm which should have rang when the day flips. The same test with the code change produces