Skip to content

Add option to write log files to output directory #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dpsarmie wants to merge 4 commits into
base: dev/emc
Choose a base branch
from
Open

Add option to write log files to output directory #180

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0f7b714
Initial logging changes
dpsarmie Jun 30, 2026
d3155a7
Add user option
dpsarmie Jun 30, 2026
bb9b9b4
Add user config option
dpsarmie Jul 1, 2026
9569a0b
Merge branch 'NOAA-EMC:dev/emc' into feature/logging_to_outputdir
dpsarmie Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions config_src/drivers/nuopc_cap/mom_cap_outputlog.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ end subroutine outputlog_restart

integer :: toffset
logical :: debug
logical :: existflag
logical :: existflag, log_to_output
character(len=256) :: restartdir
character(len=256) :: outputdir
character(len=2) :: output_fh
Expand Down Expand Up @@ -148,6 +148,12 @@ subroutine outputlog_init(gcomp, mclock, rc)
call ESMF_GridCompGet(gcomp, vm=vm, rc=rc)
if (ChkErr(rc,__LINE__,u_FILE_u)) return

log_to_output = .false.
call NUOPC_CompAttributeGet(gcomp, name="mom6_write_log_to_output_dir", value=value, &
isPresent=isPresent, isSet=isSet, rc=rc)
if (ChkErr(rc,__LINE__,u_FILE_u)) return
if (isPresent .and. isSet) log_to_output=(trim(value)=="true")

call NUOPC_CompAttributeGet(gcomp, name="mom6_restart_dir", value=value, &
isPresent=isPresent, isSet=isSet, rc=rc)
if (ChkErr(rc,__LINE__,u_FILE_u)) return
Expand Down Expand Up @@ -276,6 +282,7 @@ subroutine outputlog_run(mclock, atStopTime, rc)
character(len=16) :: timestr
character(len=256) :: fname
character(len=256) :: subname='MOM_cap:(outputlog_run)'
character(len=256), allocatable :: logdir

@DeniseWorthen DeniseWorthen Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is logdir allocatable?

Also, instead of having a check for if you want it going someplace else, why not have a config variable which would provide the location; if none were provided it would default to the cwd?

!----------------------------------------------------------------------------

rc = ESMF_SUCCESS
Expand All @@ -296,6 +303,8 @@ subroutine outputlog_run(mclock, atStopTime, rc)
fsize(1) = nf90_fill_int
nlen(1) = nf90_fill_int

if (log_to_output) logdir=outputdir

do n = 1,n_freq
write(chour,'(I2.2,A)')freq(n),'h'
if (chour(1:2) == output_fh(1:2)) then
Expand Down Expand Up @@ -348,7 +357,7 @@ subroutine outputlog_run(mclock, atStopTime, rc)
olog(n)%time_lastrestart = lastrestart
if (is_root_pe()) then
call log_restart_fh(currTime-olog(n)%fhoffset, startTime, 'mom6.'//chour, prefixtime=.true., &
lastrestart=olog(n)%time_lastrestart, lastoutput=olog(n)%filename, rc=rc)
lastrestart=olog(n)%time_lastrestart, lastoutput=olog(n)%filename, output_dir=logdir, rc=rc)
if (ChkErr(rc,__LINE__,u_FILE_u)) return
endif
endif
Expand All @@ -375,7 +384,7 @@ subroutine outputlog_run(mclock, atStopTime, rc)
olog(n)%time_lastrestart = lastrestart
if (is_root_pe()) then
call log_restart_fh(prevring, startTime, 'mom6.lstop.'//chour, prefixtime=.true., &
lastrestart=olog(n)%time_lastrestart, lastoutput=olog(n)%filename, rc=rc)
lastrestart=olog(n)%time_lastrestart, lastoutput=olog(n)%filename, output_dir=logdir, rc=rc)
if (ChkErr(rc,__LINE__,u_FILE_u)) return
endif
endif
Expand Down Expand Up @@ -407,6 +416,7 @@ subroutine outputlog_restart(mclock, num_rest_files, rc)
logical, allocatable :: allDone(:)
character(len=8) :: suffix
character(len=256) :: subname='MOM_cap:(outputlog_restart)'
character(len=256), allocatable :: logdir
!----------------------------------------------------------------------------

rc = ESMF_SUCCESS
Expand All @@ -425,6 +435,8 @@ subroutine outputlog_restart(mclock, num_rest_files, rc)
allocate(allDone(1:num_rest_files))
allDone = .false.

if (log_to_output) logdir=outputdir

do n = 1,num_rest_files
if (n == 1) then
suffix = ''
Expand Down Expand Up @@ -462,7 +474,7 @@ subroutine outputlog_restart(mclock, num_rest_files, rc)
if (all(allDone) .eqv. .true.) then
lastrestart = nextTime
if (is_root_pe()) then
call log_restart_fh(nextTime, startTime, 'mom6.res', prefixtime=.true., rc=rc)
call log_restart_fh(nextTime, startTime, 'mom6.res', prefixtime=.true., output_dir=logdir, rc=rc)
if (ChkErr(rc,__LINE__,u_FILE_u)) return
endif
endif
Expand Down
Loading