[production/GFSv17] Add output directory argument for logs - #177
Conversation
|
@jiandewang This PR was tested against the GFSv17 baselines and it can be merged into the GFSv17 production branch. Thanks |
|
@dpsarmie I didn't realize your PR comes so quickly. I am asking @DeniseWorthen to take look at your PR as we need to do code merging in a standard way. I am a bit confused, looking at ufs-community/ufs-weather-model#3171, your UFS PR was merged on Apr. 1st. How could that happen when there is no MOM6 PR at that moment ? |
|
This PR just adds an option to move the logs to ./MOM6_OUTPUT because this is a request made by NCO for the GFSv17 production code. The PR is here: ufs-community/ufs-weather-model#3240 The PR you linked already has the latest hash updates that were made when the GFSv17 branch in this repo was created: 7b80656 |
|
@dpsarmie you mean the code change in this PR is already in dev/emc MOM6, right ? |
|
@dpsarmie I see you have new commit you have not run any rt.sh yet, right ? |
|
Yes, this new commit is for the GFSv17 production branch only so it will not be in the emc/develop branch yet. For the v17 development cycle, I've been maintaining a set of GFSv17 baselines. Yes, this PR has been run using rt.sh and the regression tests in UFSWM. |
|
@dpsarmie now I fully understood your PR's purpose. |
|
@dpsarmie Let me know when it's the mature time for me to do the merging |
Yes, you can go ahead and merge. Thank you! |
|
merged |
3 participants
There is a request from NCO to move the MOM6 logs into the ./MOM6_OUTPUT directory. This change will add that argument to the logging function call in MOM6. There will be a user-controlled feature added to develop soon.