Potential fix for code scanning alert no. 25: Impossible interface nil check

[NLstn]

Potential fix for https://github.com/NLstn/go-odata/security/code-scanning/25

In general, the problem is caused by wrapping a non-interface value (here, a map[string]interface{}) into an interface{} and then comparing that interface to nil. Because processMapEntity is declared to return map[string]interface{}, assigning its result directly to a variable of type interface{} ensures the resulting interface value is never nil, making if entityMap != nil always true. To fix this, keep values in their concrete types as much as possible, and avoid unnecessary interface wrapping when your logic depends on distinguishing nil/non-nil.

The best targeted fix here is to (1) change addNavigationLinks so that it uses the same concrete type as processMapEntity—map[string]interface{}—for the processed entity, and (2) remove the impossible nil check. Specifically:

• Change the type of entityMap in addNavigationLinks from interface{} to map[string]interface{}.
• The assignments from processMapEntity already match that type.
• For the processStructEntityOrdered call, perform an explicit type assertion to map[string]interface{} (which is what it presumably returns or is convertible to), and handle the “not ok” case by skipping the assignment.
• Remove the if entityMap != nil wrapper and instead unconditionally assign to result[i] when the type assertion succeeds.
  These changes are confined to internal/response/navigation_links.go and don’t require new imports or behavior changes; they only tighten the typing and make the control flow explicit.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

[NLstn]

@copilot fix the syntax error

[Copilot]

@NLstn I've opened a new pull request, #377, to work on those changes. Once the pull request is ready, I'll request review from you.

[Copilot]

Pull request overview

This PR addresses a code scanning alert about an "impossible interface nil check" by refactoring how entity processing results are handled in the addNavigationLinks function. The original issue arose from wrapping a non-nil concrete type (map[string]interface{}) into an interface{} variable, which made the subsequent nil check always evaluate to true.

Key changes:

• Replaced a shared interface{} variable with scoped concrete-type variables for each processing path
• Added explicit nil checks for both processMapEntity and processStructEntityOrdered return values
• Entities that fail processing now leave nil entries in the result array rather than being skipped

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.