Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store the module data in an arc to simplify a lot of things #65

Merged
merged 6 commits into from
Sep 20, 2024

Conversation

tertsdiepraam
Copy link
Contributor

This PR does a couple of things:

  1. The data of compiled functions is now freed when it is no longer being used.
  2. Each TypedFunc now contains an Arc to that data to prevent it from being dropped too early.
  3. This removes the lifetime parameter from TypedFunc.
  4. Additionally, it allows us to get multiple functions from a single Roto file.
  5. Finally, TypedFunc can now be cloned!

Yay for usability at the cost of some dirty code inside.

@tertsdiepraam tertsdiepraam merged commit 71b9217 into main Sep 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant