Compatibility with latest routecore changes #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this because it's very outdated. We can still add provenance later to the current version of Roto, but that will require very different code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains several small changes: introducing a new Provenance, adapting to new routecore stuff and some miscellaneous things to make everything compile again.
Note that there are
todo!()'s here, specifically inimpl RotoType. Once we've figured out what's next for roto, these can be perhaps discard or should otherwise be properly implemented.There was some confusing re-exporting (in routecore) and renaming (in roto) going in with regards to
AfiSafi(Type). Both that re-export and renaming ('use as' in roto) are now gone, which is where all these changesAfiSafi->AfiSafiTypecome from. This was the only way the compiler wouldn't shout at me, but perhaps this has unwanted user-facing consequences. All those changes are captured in a separate commit for if we wanted to revert it, after all.