Migrate data store #1100
Merged
Migrate data store #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
August 24, 2023 10:33
1 task
Koenvh1
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Looks good.
This is a bit of a nit, but I think the flow of main could be made a bit clearer. I would abstract the actual matching of matches (i.e. line 19 of src/bin/krillup.rs and down) to another function. Now after parse_matches the code goes back to the top again. Alternatively you could inline it, or leave it as-is. I don't consider it a blocking issue, but something to perhaps consider.
Base automatically changed from
non-disk-migrations-1094
to
prep-0.14.0-rc1
September 21, 2023 11:17
timbru
pushed a commit
that referenced
this pull request
Oct 17, 2023
* Use kvx with explicit namespace type. * Do not depend on a data dir for storage. * Add support for data migration. * Add command line option to migrate data to krillup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[draft] should probably be after #1099
This PR adds support to
krillupto migrate data from one store to another. It seems to work both in unit test and by manual testing of the actualkrillupbinary.However, in doing this work I discovered that the (hidden) runtime that is used in the synchronous
kvxlib will not work with Krill - as it already has a (tokio) runtime. So that will need thought, and a separate fix and PR.