New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aggregate command sets #1087

Merged

timbru merged 28 commits into prep-0.14.0-rc1 from aggregate-command-sets

Jul 7, 2023

Contributor

timbru commented Jun 30, 2023

Tim Bruijnzeels added 14 commits

June 12, 2023 17:25


          Fix clippy warning

90a0e17


          Track krill version only once #1074

1f8fbff


          Fix imports

02b91fc


          fix typo

09eacf4


          Include events in StoredCommand

e1f5ddc


          Whole bunch of items for #1078

bf809f7


          Simplify generics for StoredCommand

0fd18e5


          Fix eventsourcing unit test

d02f254


          Fix error response regression test - accept new text

53cd550


          Fix pre-0.10.0 migration

892fce7


          Remove unnecessary ref

3e4481d


          Remove code duplication for old aggregate store migration.

3e63009


          Remove type that is no longer used.

4be09f4


          Support migrations

5720bd6

timbru linked an issue

that may be closed by this pull request

Let AggregateStore use 'ChangeSets' rather than separate Commands and Events #1078

Closed

Tim Bruijnzeels added 2 commits

June 30, 2023 11:39


          Merge branch 'prep-0.14.0-rc1' into aggregate-command-sets

4b8a7dd


          Remove PhantomData (no longer needed)

b65f12b

ximon18 reviewed

View reviewed changes

src/daemon/config.rs Outdated Show resolved Hide resolved

ximon18 reviewed

View reviewed changes

src/commons/api/history.rs Outdated Show resolved Hide resolved

ximon18 reviewed

View reviewed changes

src/commons/api/history.rs Outdated Show resolved Hide resolved

ximon18 reviewed

View reviewed changes

src/commons/api/history.rs Show resolved Hide resolved

ximon18 reviewed

View reviewed changes

src/commons/api/history.rs Outdated Show resolved Hide resolved

ximon18 reviewed

View reviewed changes

src/commons/crypto/signing/dispatch/signerinfo.rs Outdated Show resolved Hide resolved

ximon18 reviewed

View reviewed changes

src/commons/crypto/signing/dispatch/signerinfo.rs Show resolved Hide resolved

ximon18 reviewed

View reviewed changes

src/commons/eventsourcing/cmd.rs Outdated Show resolved Hide resolved

ximon18 reviewed

View reviewed changes

src/commons/eventsourcing/cmd.rs Show resolved Hide resolved

ximon18 reviewed

View reviewed changes

src/commons/eventsourcing/evt.rs Show resolved Hide resolved

ximon18 reviewed

View reviewed changes

src/commons/eventsourcing/mod.rs Show resolved Hide resolved

ximon18 reviewed

View reviewed changes

src/commons/eventsourcing/store.rs Show resolved Hide resolved

ximon18 reviewed

View reviewed changes

src/commons/eventsourcing/store.rs Outdated Show resolved Hide resolved

ximon18 reviewed

View reviewed changes

src/commons/eventsourcing/store.rs Show resolved Hide resolved

ximon18 reviewed

View reviewed changes

src/commons/eventsourcing/store.rs Show resolved Hide resolved

ximon18 reviewed

View reviewed changes

src/daemon/properties/mod.rs Outdated Show resolved Hide resolved

ximon18 reviewed

View reviewed changes

src/daemon/properties/mod.rs Show resolved Hide resolved

ximon18 reviewed

View reviewed changes

src/daemon/ta/proxy.rs Outdated Show resolved Hide resolved

ximon18 reviewed

View reviewed changes

src/daemon/ta/proxy.rs Show resolved Hide resolved

ximon18 reviewed

View reviewed changes

src/upgrades/pre_0_10_0/cas_migration.rs Show resolved Hide resolved

ximon18 reviewed

View reviewed changes

src/upgrades/mod.rs Outdated Show resolved Hide resolved

ximon18 reviewed

View reviewed changes

src/upgrades/mod.rs Outdated Show resolved Hide resolved

ximon18 reviewed

View reviewed changes

src/upgrades/pre_0_10_0/cas_migration.rs Show resolved Hide resolved

ximon18 reviewed

View reviewed changes

src/upgrades/mod.rs Show resolved Hide resolved

ximon18 reviewed

View reviewed changes

src/upgrades/mod.rs Outdated Show resolved Hide resolved

ximon18 reviewed

View reviewed changes

src/upgrades/mod.rs Outdated Show resolved Hide resolved

ximon18 approved these changes

View reviewed changes


          Use version instead of sequence for commands.

f45c704

Member

ximon18 commented Jul 5, 2023

LGTM, only very minor feedback. I like the refinements to the upgrade process. I have NOT run the test suite or tried to run Krill to verify these changes, but based on your description of the intent and approach and my subsequent reading of the changes I didn't find anything worth blocking this PR. Nice work!

Tim Bruijnzeels added 11 commits

July 6, 2023 11:49


          Use "init" consistently.

877487d


          Fix comment

8bb96b0


          Use Option<Mutex<..>> instead of Mutex<Option<..>>

2de2bd7


          Fix comment

05779b0


          Fix comment

3cddeff


          Fix migration report message.

1ee72d4


          Improve function name

10907ea


          Fix comment

affa20b


          Improve log message

625557f


          Extract exit on error for fatal storage issues.

fca8be2


          Update config file documentation.

bcfe34f

timbru merged commit e39ead0 into prep-0.14.0-rc1

18 checks passed

timbru deleted the aggregate-command-sets branch

July 7, 2023 15:12

timbru pushed a commit that referenced this pull request


          Aggregate command sets (#1087)

f48690c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet