Add RFC 1996 NOTIFY support. #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t' into stelline-server-testing-changes
ComposeRequest and ComposeRequestMulti.
…an error message.
- Add TSIG Stelline test recipe. - Update Stelline server integration tests to use the new TSIG middleware. - Remove unnecessary Unpin bounds in net::server::message::Request. - Tsig module changes: - Derive Clone for Key. - Added Key::compose_len() for determining how many response bytes to reserve. - Added From<ServerTransaction<K>> for ServerSequence<K>. - Altered KeyStore blanket impls to avoid conflict with additional impl on Arc<KeyStore>. - Various minor RustDoc improvements. - Made tsig::ServerError::unsigned() public.
…XFR query types) by explicit RequestMessageMulti support.
…n, but this time make sure it is set and unset correctly.
…s the "always drop" bug that was just fixed.
…moves all of its constituent RRs.
…y can't be a mismatch with each other.
…y can't be a mismatch with each other.
- Release the write lock on ZoneUpdate::Finished and don't allow the ZoneUpdater to be used after that. - Remove the entire RRset if its' last record is removed. - Check more in tests and add more tests.
…st is not the most efficient way to handle NOTIFY requests. Also mention more generally strategies for structuring middleware.
Philip-NLnetLabs
approved these changes
Sep 24, 2024
ximon18
added a commit
that referenced
this pull request
Sep 25, 2024
Add RFC 1996 "slave" side minimalistic NOTIFY request support, delegating the actual work to a caller supplied helper that implements a new Notifiable trait.
ximon18
added a commit
that referenced
this pull request
Oct 3, 2024
Add RFC 1996 "slave" side minimalistic NOTIFY request support, delegating the actual work to a caller supplied helper that implements a new Notifiable trait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from the
xfrbranch in order to split PR #335 into several smaller PRs.This PR adds RFC 1996 "slave" side minimalistic NOTIFY request support, delegating the actual work to a caller supplied helper that implements a new
Notifiabletrait.