Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC 9619 QDCOUNT is (usually) one #365

Merged
merged 1 commit into from
Oct 2, 2024
Merged

RFC 9619 QDCOUNT is (usually) one #365

merged 1 commit into from
Oct 2, 2024

Conversation

ximon18
Copy link
Member

@ximon18 ximon18 commented Jul 24, 2024

Since it was easy to add.

@ximon18 ximon18 requested a review from a team July 24, 2024 22:12
@partim
Copy link
Member

partim commented Oct 2, 2024

I’m assuming a query count of 0 is checked elsewhere?

@ximon18
Copy link
Member Author

ximon18 commented Oct 2, 2024

No, because:

"DNS Cookies (Section 5.4 of [RFC7873]) allow a client to receive a valid Server Cookie without sending a specific question by sending a request (QR = 0) with OPCODE = 0 and QDCOUNT = 0, with the resulting response also containing no question."

@ximon18 ximon18 changed the base branch from xfr to main October 2, 2024 19:36
@ximon18 ximon18 changed the base branch from main to xfr October 2, 2024 19:39
@ximon18 ximon18 changed the base branch from xfr to main October 2, 2024 19:46
@ximon18 ximon18 force-pushed the rfc-9619-qdcount-is-usually-one branch from 1be9325 to 525aaa0 Compare October 2, 2024 19:47
@ximon18 ximon18 merged commit a354121 into main Oct 2, 2024
26 checks passed
@ximon18 ximon18 deleted the rfc-9619-qdcount-is-usually-one branch October 2, 2024 19:54
ximon18 added a commit that referenced this pull request Oct 3, 2024
@ximon18
Extend MandatoryMiddlewareSvc with an RFC 9619 check for opcode QUERY…
205bd9b 
… with QDCOUNT > 1. (#365)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@partim partim partim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ximon18 @partim