Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make interop tests run as Rust integration tests. #364

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

ximon18
Copy link
Member

@ximon18 ximon18 commented Jul 24, 2024

By moving them under /tests so that #[cfg(test)] is not set and they do not thus get mock_instant time instead of real time.

As the interop test tests domain as a black box and against other running applications integration test seems like the right thing to do anyway, but in this case this is needed by the xfr branch which modifies Time48 to use mock time when run in test mode, i.e. when #[cfg(test)] is set. If the interop test is not moved it gets compiled with mock time and thus TSIG signature checking fails.

This PR also removes some code which doesn't seem to be used anywhere and which Clippy was complaining about.

Tested by running:

$ cargo test --all-features --test interop -- --ignored
...
test tsig_client_nsd ... ok
[2024-07-24 23:07:25.965] nsd[370539]: warning: signal received, shutting down...
test tsig_client_sequence_nsd ... ok

test result: ok. 4 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.02s

… /tests so that `#[cfg(test)]` is not set and they do not thus get mock_instant time instead of real time.
@ximon18 ximon18 requested a review from a team July 24, 2024 21:07
@partim partim merged commit 5b50a22 into main Oct 2, 2024
26 checks passed
@partim partim deleted the make-interop-test-into-integration-test branch October 2, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants