Make interop tests run as Rust integration tests. #364
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By moving them under /tests so that
#[cfg(test)]
is not set and they do not thus get mock_instant time instead of real time.As the interop test tests domain as a black box and against other running applications integration test seems like the right thing to do anyway, but in this case this is needed by the
xfr
branch which modifiesTime48
to use mock time when run in test mode, i.e. when#[cfg(test)]
is set. If the interop test is not moved it gets compiled with mock time and thus TSIG signature checking fails.This PR also removes some code which doesn't seem to be used anywhere and which Clippy was complaining about.
Tested by running: