-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qname router #353
Qname router #353
Conversation
a8f645e
to
fd688ac
Compare
beeeb80
to
2c779d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really cool feature! It took me some time to understand this part of the codebase, but looking at it now, everything seems to be quite straightforward. My primary concern is with the number of types that users need to interact with -- we should look for a way to simplify the interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small suggestions on top of Arya's.
Proof of concept for query routing. The example query-routing shows how to route to different upstreams based on the qname. The client subnet option is copied from the request to upstream and in the reply back downstream again to show option processing.
This PR adds the following to unstable-server-transport: