Skip to content

Feature/unit tests #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 13, 2016
Merged

Feature/unit tests #1

merged 3 commits into from
Mar 13, 2016

Conversation

pradtke
Copy link
Contributor

@pradtke pradtke commented Mar 12, 2016

Add some unit tests. I plan to make some future enhancements and wanted the base functionality covered with tests. Thanks for contributing the original modules

@sitya
Copy link
Contributor

sitya commented Mar 12, 2016

Thanks for the PR, it is great. I may have only two minor remark:

  • there is a missing newline from the end of .gitignore
  • IMHO line 121 in tests/lib/Auth/Process/FilterAttributesTest.php could be deleted, if we do not need it

@pradtke
Copy link
Contributor Author

pradtke commented Mar 13, 2016

I've made the suggested changes.

sitya added a commit that referenced this pull request Mar 13, 2016
@sitya
Merge pull request #1 from cirrusidentity/feature/unit-tests
8316798 
Feature/unit tests
@sitya sitya merged commit 8316798 into NIIF:master Mar 13, 2016
@sitya
Copy link
Contributor

sitya commented Mar 13, 2016

Thanks @pradtke !

@pradtke pradtke deleted the feature/unit-tests branch March 14, 2016 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pradtke @sitya