-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Library card size #1477
fix: Library card size #1477
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## ui/redesign #1477 +/- ##
===========================================
Coverage 11% 11%
===========================================
Files 268 268
Lines 7660 7660
===========================================
Hits 820 820
Misses 6840 6840 |
Looks great! Spoke with @thePeras and we find the white in the background looks a bit strange. Can you also update from the white to this new color we got in the figma rgba(177, 77, 84, 0.25)? Thanks! |
@Adriano-7 thanks for the suggestion! It was indeed looking a bit strange. I have applied the new color and updated the screenshot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Job :)
This weekend i'll create a PR correcting the colors in the theme.dart and then i'll remove the hardcoded colors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
@peucastro It is ready to go? |
I'm just waiting for this card to be integrated at #1449 so I can test if there are any issues there. Anyhow, I'll mark this pr as ready for review if you need it to be merged ASAP. |
Let @Pinho13 fix any issues may come up with the integration. He needs to work 😄 |
Closes #1474
Fixes the issue regarding the weird size/shape of the library card when inserted at the home and faculty pages.
Homepage preview:
Review checklist
whatsnew/whatsnew-pt-PT
changelog.md
with the change