Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Library card size #1477

Merged
merged 2 commits into from
Feb 15, 2025
Merged

fix: Library card size #1477

merged 2 commits into from
Feb 15, 2025

Conversation

peucastro
Copy link
Member

@peucastro peucastro commented Feb 12, 2025

Closes #1474
Fixes the issue regarding the weird size/shape of the library card when inserted at the home and faculty pages.

Homepage preview:

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@peucastro peucastro self-assigned this Feb 12, 2025
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11%. Comparing base (4ec1472) to head (e69c35d).
Report is 4 commits behind head on ui/redesign.

Additional details and impacted files
@@             Coverage Diff             @@
##           ui/redesign   #1477   +/-   ##
===========================================
  Coverage           11%     11%           
===========================================
  Files              268     268           
  Lines             7660    7660           
===========================================
  Hits               820     820           
  Misses            6840    6840           

@Adriano-7
Copy link
Member

Adriano-7 commented Feb 12, 2025

Looks great!

Spoke with @thePeras and we find the white in the background looks a bit strange. Can you also update from the white to this new color we got in the figma rgba(177, 77, 84, 0.25)? Thanks!

@peucastro
Copy link
Member Author

Looks great!

Spoke with @thePeras and we find the white in the background looks a bit strange. Can you also update from the white to this new color we got in the figma rgba(177, 77, 84, 0.25)? Thanks!

@Adriano-7 thanks for the suggestion! It was indeed looking a bit strange. I have applied the new color and updated the screenshot.

Copy link
Member

@Adriano-7 Adriano-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job :)

This weekend i'll create a PR correcting the colors in the theme.dart and then i'll remove the hardcoded colors

@Adriano-7 Adriano-7 requested a review from a team February 14, 2025 15:52
Copy link
Member

@vitormpp vitormpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@thePeras
Copy link
Member

@peucastro It is ready to go?

@peucastro
Copy link
Member Author

@peucastro It is ready to go?

I'm just waiting for this card to be integrated at #1449 so I can test if there are any issues there. Anyhow, I'll mark this pr as ready for review if you need it to be merged ASAP.

@peucastro peucastro marked this pull request as ready for review February 15, 2025 13:01
@thePeras thePeras merged commit 2a231c1 into ui/redesign Feb 15, 2025
6 checks passed
@thePeras thePeras deleted the fix/library-card-size branch February 15, 2025 13:08
@thePeras
Copy link
Member

Let @Pinho13 fix any issues may come up with the integration. He needs to work 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants