-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix courses page when no courses appear #1468
base: ui/redesign
Are you sure you want to change the base?
Conversation
517bae0
to
c43a725
Compare
Codecov ReportAttention: Patch coverage is
❌ Your project check has failed because the head coverage (11%) is below the target coverage (70%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## ui/redesign #1468 +/- ##
===========================================
+ Coverage 11% 11% +1%
===========================================
Files 268 269 +1
Lines 7660 7685 +25
===========================================
+ Hits 820 823 +3
- Misses 6840 6862 +22 |
It looks good, however I do not think it is well centered across the entire scaffold |
51d5f2f
to
d35aabf
Compare
packages/uni_app/lib/view/academic_path/widgets/no_courses_widget.dart
Outdated
Show resolved
Hide resolved
Co-authored-by: Henrique Fernandes <[email protected]>
Closes #1467
Review checklist
whatsnew/whatsnew-pt-PT
changelog.md
with the change