Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix courses page when no courses appear #1468

Open
wants to merge 10 commits into
base: ui/redesign
Choose a base branch
from

Conversation

Process-ing
Copy link
Contributor

@Process-ing Process-ing commented Feb 6, 2025

Closes #1467

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@Process-ing Process-ing force-pushed the fix/course-grade-card-link branch from 517bae0 to c43a725 Compare February 6, 2025 19:28
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 7.69231% with 36 lines in your changes missing coverage. Please review.

Project coverage is 11%. Comparing base (4ec1472) to head (a87a8af).
Report is 1 commits behind head on ui/redesign.

❌ Your project check has failed because the head coverage (11%) is below the target coverage (70%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           ui/redesign   #1468   +/-   ##
===========================================
+ Coverage           11%     11%   +1%     
===========================================
  Files              268     269    +1     
  Lines             7660    7685   +25     
===========================================
+ Hits               820     823    +3     
- Misses            6840    6862   +22     

@DGoiana
Copy link
Collaborator

DGoiana commented Feb 8, 2025

It looks good, however I do not think it is well centered across the entire scaffold

@Process-ing Process-ing force-pushed the fix/course-grade-card-link branch from 51d5f2f to d35aabf Compare February 11, 2025 15:46
@Process-ing Process-ing requested a review from DGoiana February 11, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants