Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumped mongoose to v6.5.2 #245

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Bumped mongoose to v6.5.2 #245

merged 1 commit into from
Aug 18, 2022

Conversation

BrunoRosendo
Copy link
Member

@BrunoRosendo BrunoRosendo commented Aug 17, 2022 •
edited
Loading

No description provided.

@Naapperas
Copy link
Member

Naapperas commented Aug 17, 2022 •
edited
Loading

Some tests will need to be rewritten.

Luckily they are all in the companies E2E file

@BrunoRosendo
Copy link
Member Author

That's fine, I've fixed those. I'm going a bit crazy with some other tests that are mysteriously failing

@Naapperas
Copy link
Member

That's fine, I've fixed those. I'm going a bit crazy with some other tests that are mysteriously failing

Push and I can also try and look into it

@BrunoRosendo BrunoRosendo force-pushed the audit/bumpMongoose6.5.2 branch from 282de4c to f896ccf Compare August 17, 2022 19:45
@Naapperas
Copy link
Member

Remove the .idea and documentation folders

@BrunoRosendo BrunoRosendo force-pushed the audit/bumpMongoose6.5.2 branch 2 times, most recently from 26d2ddd to 9ad9642 Compare August 17, 2022 20:15
@Naapperas
Copy link
Member

Fix the tests only as much as needed, any further refactoring on the tests should come only when #169 is dealt with.

@BrunoRosendo
Copy link
Member Author

For the record, this afterAll() seems to be deleting the wrong offer, used in tests below. I'll continue investigating tomorrow
image

@BrunoRosendo BrunoRosendo force-pushed the audit/bumpMongoose6.5.2 branch from 9ad9642 to f629f28 Compare August 18, 2022 14:23
@BrunoRosendo BrunoRosendo marked this pull request as ready for review August 18, 2022 14:24
@BrunoRosendo
Copy link
Member Author

For the record, this afterAll() seems to be deleting the wrong offer, used in tests below. I'll continue investigating tomorrow image

This query was wrong. Before, it didn't delete anything but now it treats it as an empty object and deletes every offer

@BrunoRosendo BrunoRosendo force-pushed the audit/bumpMongoose6.5.2 branch from f629f28 to 50d7cf0 Compare August 18, 2022 14:30
@BrunoRosendo
Copy link
Member Author

BrunoRosendo commented Aug 18, 2022 •
edited
Loading

@Naapperas Everything should be fine now 😌 , I'm just going to see if there are things we can simplify with the new version

@BrunoRosendo BrunoRosendo marked this pull request as draft August 18, 2022 14:37
@Naapperas Naapperas mentioned this pull request Aug 18, 2022
Merged
@BrunoRosendo BrunoRosendo force-pushed the audit/bumpMongoose6.5.2 branch from 50d7cf0 to 22e114e Compare August 18, 2022 15:25
@BrunoRosendo BrunoRosendo marked this pull request as ready for review August 18, 2022 15:25
@BrunoRosendo BrunoRosendo requested a review from Naapperas August 18, 2022 15:25
Naapperas
Naapperas previously approved these changes Aug 18, 2022
View reviewed changes
@BrunoRosendo BrunoRosendo force-pushed the audit/bumpMongoose6.5.2 branch from 22e114e to f971961 Compare August 18, 2022 15:54
@BrunoRosendo BrunoRosendo requested a review from Naapperas August 18, 2022 15:59
@BrunoRosendo BrunoRosendo merged commit 6da1c15 into develop Aug 18, 2022
@BrunoRosendo BrunoRosendo deleted the audit/bumpMongoose6.5.2 branch August 18, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naapperas Naapperas Naapperas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrunoRosendo @Naapperas