-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forgot Password #42
Forgot Password #42
Conversation
5880ced
to
64cd1f8
Compare
…f a redirect from a signed page
…ear in send forgot password email
I already applied your requested changes and I noticed now that I had forgotten to push the two commits where I changed the rate limiter and started getting the parameters of the the change password form in the backend instead of the frontend |
I know this is not the pr that deals with the register, but does your app stop when you register a new account? |
Do you have a local instance of From what I've tried, having an instance of mailpit does not block after register but if I do not have it, it blocks because there is no connection to the smpt server the website is exepecting to have |
Oops... That was it, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My observations are some nice to have changes and some discussions, changing them is not necessary. If you either change them or not is up to you.
Awesome work! :)
Checklist of what still needs to be done
I've followed the OWASP guidelines.
As per the guidelines, there is no warning shown to the user resetting the password whether the requested email exists or not. However, we internally will not send an email if that email does not belong to any account.