Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional (optional) output for crown area #1131

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

mpaiao
Copy link
Contributor

@mpaiao mpaiao commented Dec 8, 2023

Description:

  • Edited FatesHistoryInterfaceMod.F90 to include two output variables (FATES_CROWNAREA_CANOPY_SZPF and FATES_CROWNAREA_USTORY_SZPF). Both are inactive by default.
  • Replaced scaling for additional crown area variables. Results should be numerically identical but the calculation is consistent with other instances. This addresses issue Scaling of cohort crown area in the output files? #1126.

Collaborators:

@ckoven

Expectation of Answer Changes:

No change in answers expected.

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided

Documentation

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

@glemieux glemieux added the history output Pertaining to FATES history output variables label Dec 8, 2023
Copy link
Contributor

@rgknox rgknox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty straight forward, seem like useful variables, no issues

@rgknox
Copy link
Contributor

rgknox commented Jan 19, 2024

Tests on derecho are OK, merging

@rgknox rgknox merged commit 7805da8 into NGEET:main Jan 19, 2024
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
history output Pertaining to FATES history output variables
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants