Skip to content

Fix release-drafter: $RESOLVED_VERSION not $INPUT_VERSION#10

Merged
NF0T merged 20 commits into
mainfrom
develop
Jun 2, 2026
Merged

Fix release-drafter: $RESOLVED_VERSION not $INPUT_VERSION#10
NF0T merged 20 commits into
mainfrom
develop

Conversation

@NF0T

@NF0T NF0T commented Jun 2, 2026

Copy link
Copy Markdown
Owner

$INPUT_VERSION is not a release-drafter template variable — the action resolves the version (from labels or the version: input) into $RESOLVED_VERSION. Using an unknown variable causes it to print literally as v$INPUT_VERSION.

The action log for run 26792124995 confirmed the version was being passed and resolved correctly (RESOLVED_VERSION: 26.6.1) while the name and tag still showed v$INPUT_VERSION — proving the workflow was never the problem, only the template variable name.

🤖 Generated with Claude Code

NF0T and others added 20 commits April 29, 2026 16:32
…ation

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replaces the placeholder onNewLog() slot with a fully working log-rotation
workflow for SQLite deployments.

- DatabaseInterface: add clearQsos() pure virtual
- SqlBackendBase: implement clearQsos() as DELETE FROM qsos (schema preserved)
- NewLogDialog: new dialog offering Archive-and-start-fresh or Discard modes;
  file chooser enabled only for Archive, OK gated until path is filled
- MainWindow::onNewLog(): exec dialog, optionally export ADIF archive via
  AdifWriter, call clearQsos(), refresh model and status bar
- MainWindow ctor: disable File → New Log when MariaDB backend is active

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Documents the YY.MM.MICRO[.PATCH] scheme, lists the three required
changes (CMakeLists.txt, release-drafter version-resolver removal,
roadmap identifiers), and notes that existing v0.x.0 tags are unchanged.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
When triggered by a pull_request event, release-drafter sets
target_commitish to refs/pull/N/merge which GitHub's releases API
rejects. The action only needs to run on push to main. Also drops
the now-unnecessary pull-requests write permission.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Direct commits to develop (roadmap updates, version bumps, small fixes)
were triggering three full platform builds each. CI now runs on push to
main and on all PRs — the two cases where a green build actually gates
something.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adopts YY.MM.MICRO CalVer scheme for all releases after v0.4.0.
CMakeLists.txt version bumped to 26.6.1; release-drafter updated to
use explicit $INPUT_VERSION rather than label-derived auto-bumping;
workflow_dispatch added so maintainer can set the CalVer string when
cutting a release draft.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Implements the CTY.dat callsign lookup chain described in the roadmap.
CtyDatLookupProvider parses the AD1C Big CTY file at startup and
performs synchronous prefix/exact-match lookups (no network, no
debounce). The lookup chain now fires CTY.dat immediately on callsign
entry and supplements with QRZ XML after the 600 ms debounce;
mergeQrzIntoCty() applies field-precedence rules (CTY.dat authoritative
for zone/DXCC/entity; QRZ overrides lat/lon/grid and fills personal
data). The Callsign class's hardcoded prefix table is retired in favour
of CTY.dat. Settings page gains a CTY.dat group box with enable toggle,
file-date status, and an in-app Update button.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds a three-page guided dialog (configure target, dry-run results,
migration progress) that transfers all QSOs from the active backend to
a clean target backend without a round-trip through ADIF.

Key design points:
- Dry-run uses a transaction+rollback on the target for an exact preview
  of transferred/duplicate counts with no permanent side-effects
- Non-empty targets and same-direction (SQLite→SQLite) are refused with
  a clear message directing users to ADIF Import/Export for merges
- Main window enters a locked state during migration: entry panel,
  New QSO, QSL upload/download, and digital listeners are all suspended
- On success the user may opt to switch the active backend in Settings;
  MainWindow re-opens the target database immediately
- Also fixes a pre-existing MariaDB config key mismatch in
  openDefaultDatabase() ("name"/"user" → "database"/"username")
- Adds beginTransaction/commitTransaction/rollbackTransaction to
  DatabaseInterface and SqlBackendBase

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Declares permissions: contents: read at the workflow level, which is
the minimum required by actions/checkout. Resolves all three
actions/missing-workflow-permissions code scanning findings.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
CTY.dat and database migration tool assigned to v26.6.1 and marked
shipped. README project status updated to v26.6.1.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
$INPUT_VERSION rendered literally because the push-to-main trigger has no
workflow_dispatch input, leaving version: empty. Now checks out the repo
and extracts the version from CMakeLists.txt as the default; the
workflow_dispatch manual input still overrides when provided.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
'VERSION [0-9]' matched cmake_minimum_required(VERSION 3.20) first;
'3.20' has only two components so the subsequent grep -oP for
\d+\.\d+\.\d+ returned nothing and exit code 1. Anchoring with ^\s*
skips the unindented cmake_minimum_required line and matches only the
indented VERSION field inside the project() block.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
$INPUT_VERSION is not a release-drafter template variable — the action
resolves the version (whether from labels or the version: input) into
$RESOLVED_VERSION. Using an unknown variable causes it to render
literally as the string '$INPUT_VERSION'. The action log confirmed
RESOLVED_VERSION was correctly set to 26.6.1 while name/tag still
showed v$INPUT_VERSION.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@NF0T NF0T added the chore Maintenance, cleanup, housekeeping label Jun 2, 2026
@NF0T NF0T merged commit 18619dd into main Jun 2, 2026
6 checks passed
@NF0T NF0T deleted the develop branch June 2, 2026 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance, cleanup, housekeeping

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant