Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fileset for system module #55

Merged
merged 14 commits into from
Feb 15, 2023
Merged

Add fileset for system module #55

merged 14 commits into from
Feb 15, 2023

Conversation

widhalmt
Copy link
Member

fixes #54

Beginning with release version 8 you need to give a fileset for "system" module of filebeat. Version 7 just used defaults.

Since we are thinking about replacing modules by elastic agents and filebeat only without modules in special cases, I add a quick fix and flag it as experimental. Let's see how it works.

fixes #54

Beginning with release version 8 you need to give a fileset for "system"
module of filebeat. Version 7 just used defaults.

Since we are thinking about replacing modules by elastic agents and
filebeat only without modules in special cases, I add a quick fix and
flag it as experimental. Let's see how it works.
@widhalmt widhalmt added the bug Something isn't working label Feb 10, 2023
@widhalmt widhalmt added this to the 1.0.0 milestone Feb 10, 2023
@widhalmt widhalmt self-assigned this Feb 10, 2023
@widhalmt
Copy link
Member Author

My initial diagnosis was wrong: https://discuss.elastic.co/t/filebeat-setup-exiting-module-system-is-configured-but-has-no-enabled-filesets/311584 . We just need to change the way we setup modules. Please note that #77 could make using modules in filebeat completely obsolete. Therefore I didn't put much effort in clean code for enabling modules. If we want to continue to support, we should find a better way than just running the same code over and over again.

@widhalmt
Copy link
Member Author

Default configuration with added modules will connect Filebeat to Logstash and then run filebeat setup. For all that I know, this won't work. (Even when it did in a local test). So either don't allow that combination or skip setup when talking to Logstash.

Or, the most sophisticated solution: Make sure, Filebeat talks to Elasticsearch when doing setup and then connect to Logstash. This could help with working with differently configured beats. But it would need more thinking than what I have time for now.

@pdolinic pdolinic self-requested a review February 14, 2023 18:47
pdolinic
pdolinic previously approved these changes Feb 14, 2023
afeefghannam89
afeefghannam89 previously approved these changes Feb 14, 2023
@widhalmt widhalmt dismissed stale reviews from afeefghannam89 and pdolinic via 0dd6a13 February 15, 2023 10:15
@afeefghannam89 afeefghannam89 self-requested a review February 15, 2023 10:20
afeefghannam89
afeefghannam89 previously approved these changes Feb 15, 2023
@widhalmt widhalmt enabled auto-merge February 15, 2023 15:33
Copy link
Member

@danopt danopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@widhalmt widhalmt added this pull request to the merge queue Feb 15, 2023
Merged via the queue into main with commit c618928 Feb 15, 2023
@widhalmt widhalmt deleted the fix/filebeat-fileset-54 branch February 15, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enabling modules in version 8 needs filesets
4 participants