Fix combination of oss and release version #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no `oss` version of Elastic Stack after version 7.x. So we need to make sure we don't run tests for variants that don't even exist. That can mean to pin tests to a certain release. Meaning we run the same test twice which is a bit of a waste of ressources but will only be neccessary as long as 7.x is supported. Or changing the variant to `elastic` where appropriate.
widhalmt
requested review from
mkayontour,
danopt,
afeefghannam89,
Crited and
pdolinic
Merged
pdolinic
approved these changes
Feb 9, 2023
ivareri
pushed a commit
to ivareri/ansible-collection-elasticstack
that referenced
this pull request
Jun 17, 2025
Fix combination of oss and release version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no
ossversion of Elastic Stack after version 7.x. So we need to make sure we don't run tests for variants that don't even exist.That can mean to pin tests to a certain release. Meaning we run the same test twice which is a bit of a waste of ressources but will only be neccessary as long as 7.x is supported. Or changing the variant to
elasticwhere appropriate.