Review and refactoring of the collection #395
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbauriedel
added
the
breaking-change
tbauriedel
changed the title
elasticstack_full_stack to elasticstack_collection_managed
tbauriedel
added
the
quality
tbauriedel
force-pushed
the
development
branch
from
d35e0c0 to
56c5751
Compare
There were an known issue with EL 9 that has been solved by elastic itself. We dont need it anymore. elastic/elasticsearch#85876
tbauriedel
force-pushed
the
development
branch
from
c053850 to
c5b90a3
Compare
This variable is only part of the `repos` role. There is no need to define it inside the `elasticstack` role.
`repos_deb_remove_legacy_key` can be used to remove an existing key from the trusted.gpg keyring
Keep an straight line for comments in templates, newlines in yaml files and yaml syntxa in general
afeefghannam89
previously approved these changes
Sep 25, 2025
Sure. This will be documented. For now I just wanted to see if everything works and let the pipelines run :D |
There are tasks that are doing things with other tools of the collection (e.g: after changing certificates in elasticsearch, we need to restart kibana). This tasks will be moved to the global role "elasticstack" and can be called by via 'notify'. Also, global handlers will only do something when `elasticstack_collection_managed` is true (means the whole stack is managed by the collecion)
tbauriedel
force-pushed
the
development
branch
from
611711f to
1fe1c2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to add some refactoring development. Will grow over time.
Part of #396
A list of changes can be found below.
elasticstack_full_stacktoelasticstack_collection_managed[Question]: Renamefull_stackvariable - Please let us know your ideas #316 68535e3repos56c5751elasticstack_enable_repostorepos_enable_reposand move into thereposrole itself 2e7d808repos_deb_remove_legacy_keyto remove key from the deprecated trusted.gpg keyring 4aa385ffixes #316