Fix package naming #368
Merged
Fix package naming #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
widhalmt
requested changes
Mar 5, 2025
There was a problem hiding this comment.
Thanks for your contribution!
Fixing the bug with the version separator being present when installing oss versions will help a lot.
I saw your changes would also alway install the latest version of the packages which is not desireable. First, you want to have control over when a new version is installed, second checking for new versions will slow down the execution by a lot.
Also, please make sure to have only one change per PR. So one PR for the bug of with the versionseparator and one for updating to latest.
I know, it's a bit stupid of me to add suggestions for something that needs to be removed, but maybe it will help with the next PR.
|
Related to #371 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
The package name for the OSS version had a trailing "-" at the end.
The packages were not updated to the latest version when no version was provided.