Fix YAML/Jinja2 syntax #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcndsmr
approved these changes
Aug 23, 2023
TIL: * Logstash can read YAML. Logstash config check CAN NOT. * Logstash documentation lists per-pipeline and global options in the same list. Config check does not allow to mix them * Sometimes it just sucks to be alive Damn, that cost a lot of time and local debugging in test hosts.
This is a more serious problem. I opened a separate issue for it: #246
widhalmt
changed the title
Actually we won't be able to change that easily. So I disabled the warning. I know, I opted for warning in the first place but seeing all the warnings without a way to solve them, I changed my mind.
It breaks idempotence
|
I tried failing checks locally. Release |
|
Both worked, so I'm merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and other problems that make our checks fail. I try hard to only use configuration in Molecule or quick workarounds. Every issue I find will go into it's own issue in this repository.
fixes #242