Skip to content

Fix failing cluster checks #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 1, 2023
Merged

Fix failing cluster checks #148

merged 11 commits into from
Jun 1, 2023

Conversation

widhalmt
Copy link
Member

@widhalmt widhalmt commented Apr 6, 2023

Fix cluster checks failing without log output

fixes #147
Fix #170 remove repetitive pipelines
Make full stack pipelines run daily and manually before release.

@widhalmt widhalmt added the bug Something isn't working label Apr 6, 2023
@widhalmt widhalmt added this to the 1.0.0 milestone Apr 6, 2023
@widhalmt widhalmt self-assigned this Apr 6, 2023
@widhalmt widhalmt marked this pull request as draft April 6, 2023 11:47
@afeefghannam89
Copy link
Member

@widhalmt I think this PR can be closed. The failing checks will be removed with this PR #122

@widhalmt
Copy link
Member Author

Thanks... but! You found a very valid point when we talked offline. The checks for the cluster being ready will fail anyway. So I'll build a fix for that into this PR.

@widhalmt widhalmt marked this pull request as ready for review May 17, 2023 10:54
@widhalmt widhalmt requested a review from afeefghannam89 May 17, 2023 10:54
@widhalmt
Copy link
Member Author

Linter fails because of #159 . Needs #160 to be merged.

Thanks @afeefghannam89 for pointing that out.
@widhalmt widhalmt enabled auto-merge May 17, 2023 11:31
auto-merge was automatically disabled May 19, 2023 10:58

Merge queue setting changed

@widhalmt widhalmt enabled auto-merge May 19, 2023 11:00
@afeefghannam89 afeefghannam89 disabled auto-merge June 1, 2023 16:46
@afeefghannam89 afeefghannam89 merged commit d48bf7b into main Jun 1, 2023
@afeefghannam89 afeefghannam89 deleted the fix/clusterchecks-147 branch June 1, 2023 19:25
ivareri pushed a commit to ivareri/ansible-collection-elasticstack that referenced this pull request Jun 17, 2025
* Remove variables to check defaults
* Failsafe for conditional

fixes NETWAYS#4
ivareri pushed a commit to ivareri/ansible-collection-elasticstack that referenced this pull request Jun 17, 2025
Fix cluster checks failing without log output

fixes NETWAYS#147
Fix NETWAYS#170 remove repetitive pipelines
Make full stack pipelines run daily and manually before release.
---------

Co-authored-by: Afeef Ghannam <[email protected]>
Co-authored-by: Afeef Ghannam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework GitHub pipelines Cluster checks fail
2 participants