Show more meaningful errormessages for API #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afeefghannam89
approved these changes
Mar 13, 2023
ivareri
pushed a commit
to ivareri/ansible-collection-elasticstack
that referenced
this pull request
Jun 17, 2025
* Build connector functionality for git pipelines Thanks, @afeefghannam89 * Add new Molecule scenario to check pipelines * Run basic tests for custom pipelines * Test update of pipeline code fixes NETWAYS#117
ivareri
pushed a commit
to ivareri/ansible-collection-elasticstack
that referenced
this pull request
Jun 17, 2025
The current variant might not be very helpful when it comes to errormessages. But it will work better with slow setups. We *could* use the code I removed (see commits in between, there were also more checks) and just don't fail with the API query. I'm open for suggestions. Personally I like the current variant - it's just sleeker. fixes NETWAYS#100 fixes NETWAYS#95
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current variant might not be very helpful when it comes to errormessages. But it will work better with slow setups.
We could use the code I removed (see commits in between, there were also more checks) and just don't fail with the API query. I'm open for suggestions. Personally I like the current variant - it's just sleeker.
fixes #100
fixes #95