Remove variable debug checks - #734
Merged
Merged
Conversation
climbfuji
marked this pull request as ready for review
April 17, 2026 17:50
peverwhee
approved these changes
Apr 17, 2026
dustinswales
approved these changes
Apr 17, 2026
mkavulich
added
the
hackathon_20260417
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove variable debug checks from capgen. This is no longer necessary due to a combination of better compiler flags and changes that were made over the last years for optional arguments, passing variables to the groups etc.
Note. We need to retain a (renamed) part of the logic to ensure that variables and dimensions for optional arguments are passed down to the groups. This was uncovered when removing the variable debug checks.
User interface changes?: Yes no more
--debugflag for capgenFixes: Part of the 2026/04/17 hackathon to simplify the capgen code and get capgen to work with DDTs being passed down to the group caps.
Testing: no changes, all pass
test removed:
unit tests:
system tests:
manual testing: