Skip to content

Add fresh flag to suggested cmake commands for testing - #699

Merged
mkavulich merged 5 commits into
NCAR:developfrom
peverwhee:add-fresh
Dec 4, 2025
Merged

Add fresh flag to suggested cmake commands for testing#699
mkavulich merged 5 commits into
NCAR:developfrom
peverwhee:add-fresh

Conversation

@peverwhee

Copy link
Copy Markdown
Collaborator

Adds --fresh flag to example cmake commands; tests don't otherwise pick up changes without a clean build directory.

@climbfuji climbfuji left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also make this change in .github/{workflows,actions}/* ?

@peverwhee

Copy link
Copy Markdown
Collaborator Author

@DomHeinzeller good call - can't hurt. done!

@peverwhee
peverwhee requested a review from climbfuji December 1, 2025 18:00

@gold2718 gold2718 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but the change should also be added to #691.

@climbfuji

Copy link
Copy Markdown
Collaborator

This looks good but the change should also be added to #691.

Shouldn't we just merge this and update #691 from develop?

@peverwhee

Copy link
Copy Markdown
Collaborator Author

@climbfuji I bet @gold2718 means that we should add the flag to the README in the new nested suites test (which doesn't exist on develop yet)

@climbfuji

Copy link
Copy Markdown
Collaborator

@climbfuji I bet @gold2718 means that we should add the flag to the README in the new nested suites test (which doesn't exist on develop yet)

Got it, thanks. I added it as a suggestion so that we can add it before merging and don't forget.

@mkavulich

Copy link
Copy Markdown
Collaborator

@climbfuji I bet @gold2718 means that we should add the flag to the README in the new nested suites test (which doesn't exist on develop yet)

Got it, thanks. I added it as a suggestion so that we can add it before merging and don't forget.

@climbfuji Does this mean this PR needs an update after the merge from develop?

Add --fresh for cmake call in nested suite README
@climbfuji

Copy link
Copy Markdown
Collaborator

@climbfuji I bet @gold2718 means that we should add the flag to the README in the new nested suites test (which doesn't exist on develop yet)

Got it, thanks. I added it as a suggestion so that we can add it before merging and don't forget.

@climbfuji Does this mean this PR needs an update after the merge from develop?

Done in cdb180a

@mkavulich
mkavulich merged commit 22bc1a5 into NCAR:develop Dec 4, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants