-
Notifications
You must be signed in to change notification settings - Fork 12
The added code... Mariam & Aisha #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MaryJoK
wants to merge
1
commit into
NBHS-STEM:master
Choose a base branch
from
MaryJoK:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,4 @@ | ||
| import json | ||
|
|
||
|
|
||
| def open_library(filename): | ||
| # Create empty dictionaries just in case the library file is empty | ||
| students = {} | ||
|
|
@@ -10,8 +8,7 @@ def open_library(filename): | |
| # We use the with keyword so we don't have to explicitly close the file | ||
| # later. | ||
| # | ||
| # Alternatively you could use: | ||
| # | ||
| # Alternatively you could use: # | ||
| # f = open(filename) | ||
| # data = json.load(f) | ||
| # f.close() | ||
|
|
@@ -21,18 +18,15 @@ def open_library(filename): | |
| with open(filename) as f: | ||
| data = json.load(f) | ||
|
|
||
| # If there are students or books in the library, | ||
| # overwrite the empty dictionaries we created | ||
| # If there are students or books in the library, # overwrite the empty dictionaries we created | ||
| if data['students'] != {}: | ||
| students = data['students'] | ||
|
|
||
| if data['books'] != {}: | ||
| books = data['books'] | ||
|
|
||
| # Return the data we loaded from the file | ||
| return students, books | ||
|
|
||
|
|
||
| def add_book(filename, isbn, title, author): | ||
| # Here's a start | ||
| students, books = open_library(filename) | ||
|
|
@@ -43,46 +37,69 @@ def add_book(filename, isbn, title, author): | |
| # to the books object. | ||
|
|
||
| books[isbn] = {'title': title, 'author':author} | ||
|
|
||
| # Finally, write code that writes the new data to the library | ||
| # Do we need to return anything? | ||
| with open(filename) as f: | ||
| json.dump({'students':students,'books':books}, f) | ||
|
|
||
|
|
||
|
|
||
| def remove_book(filename, isbn): | ||
| students, books = open_library(filename) | ||
|
|
||
| # How can we *remove* an item from a dictionary? | ||
| # Write code to delete the book keyed by isbn in the space below | ||
|
|
||
| if 'isbn' in books: | ||
| del books['isbn'] | ||
| # Now write code that saves the new version of the data to your library | ||
|
|
||
| with open(filename) as f: | ||
| json.dump ({'students' : students, 'books' : books} ,f) | ||
|
|
||
| def check_out(filename, isbn, s_id): | ||
| students, books = open_library(filename) | ||
|
|
||
| # Find a way to mark a book as checked out. Be sure to associate | ||
| # the book with the student who borrowed it! | ||
|
|
||
|
|
||
| checked_out = {} | ||
| if 'isbn' in books: | ||
| checked_out.updated(books[isbn]) | ||
|
|
||
| # And again save the data here | ||
|
|
||
| with open(filename) as f: | ||
| json.dump({'students' : students, 'books' : books} ,f) | ||
|
|
||
| pass | ||
|
|
||
|
|
||
| def return_book(filename, isbn): | ||
| students, books = open_library(filename) | ||
|
|
||
| if 'isbn' in checked_out: | ||
| books.updated(checked_out) | ||
|
|
||
| # Now ensure that the book is no longer checked out and save the changes | ||
| # to the library. | ||
|
|
||
|
|
||
| with open(filename) as f: | ||
| json.dump({'students' : students, 'books' : books} ,f) | ||
|
|
||
| pass | ||
|
|
||
|
|
||
| def status(filename): | ||
| students, books = open_library(filename) | ||
|
|
||
| if books[isbn] == True: | ||
| return book[isbn] | ||
| else: | ||
| return checked_out[isbn] | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
|
||
| # Print out two lists - one of all books currently checked out, | ||
| # and one of all available books. | ||
|
|
||
|
|
||
| with open(filename) as f: | ||
| json.dump({'students' : students, 'books' : books} ,f) | ||
| pass | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if you run this function twice? It seems to me every time the function is run, the checked_out dictionary is reset.