fix: created COOKIE CONSENT FORM feature flag #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snmln
requested review from
AliceR,
hanbyul-here,
dzole0311 and
sandrahoang686
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
snmln
changed the title
snmln
changed the title
snmln
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket: {link related ticket here}
Description of Changes
GHG team communicated issues with the cookie consent ENV flag. There is no existing ENV flag, this component was previously designed to leverage the existence of
cookieConsentFormcontent as a ternary validation to conditionally show the cookie consent form or not. for future maintenance of this item I have added a cookie consent flagENABLE_COOKIE_CONSENT_FORMto enable the standard functionality.Notes & Questions About Changes
Added
ENABLE_COOKIE_CONSENT_FORMto the .env .Validation / Testing
To test pull down branch and navigation to
.envfile and changeENABLE_COOKIE_CONSENT_FORM = TRUEYou might also need to delete your local cookies by opening dev tools > application tab > cookies > right click 'clear'. Confirm that the cookie consent form renders on the front-end.Go to
.envfile and changeENABLE_COOKIE_CONSENT_FORM = FALSEconfirm that the cookie consent form does not render on the front-end.