fix: Add wrapping div for scrollytelling map and chapters #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the legacy instance was using a lazyload-wrapper this wasn't necessary, but for instances not using this approach, the additional wrapping div is actually required to build the layout as intended. It doesn't hurt the legacy either.
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dzole0311
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket: Fix #1418
Description of Changes
Since the legacy instance was using a lazyload-wrapper this wasn't necessary*, but for instances not using this approach, the additional wrapping div is actually required to build the layout as intended. It doesn't hurt the legacy either.
* The LazyLoad component from 'react-lazyload' creates a wrapping div with
class="lazyload-wrapper "Validation / Testing
Go to a story, make sure you can scroll down all the way to see text content below the scrollymap, as well as map comparison blocks.
Corresponding deploy preview from next-veda-ui: https://deploy-preview-43--veda-ui-next-test.netlify.app/stories/air-quality-and-covid-19