Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrollytelling doesn't scroll away even when the scrollytelling section is done #1418

Closed
Tracked by #1282
AliceR opened this issue Jan 30, 2025 · 0 comments · Fixed by #1437
Closed
Tracked by #1282

Scrollytelling doesn't scroll away even when the scrollytelling section is done #1418

AliceR opened this issue Jan 30, 2025 · 0 comments · Fixed by #1437
Assignees
@AliceR

Comments

@AliceR
Copy link
Member

AliceR commented Jan 30, 2025 •
edited
Loading

from the next instance preview: https://deploy-preview-41--veda-ui-next-test.netlify.app/stories/air-quality-and-covid-19
@AliceR AliceR mentioned this issue Jan 30, 2025
Open
13 tasks
@AliceR AliceR changed the title scrollytelling doesn't scroll away even when the scrollytelling section is done (from the next instance preview!) https://deploy-preview-41--veda-ui-next-test.netlify.app/stories/air-quality-and-covid-19 Scrollytelling doesn't scroll away even when the scrollytelling section is done Jan 30, 2025
@AliceR AliceR mentioned this issue Jan 30, 2025
Merged
@AliceR AliceR self-assigned this Feb 3, 2025
This was referenced Feb 4, 2025
Merged
Closed
AliceR added a commit that referenced this issue Feb 5, 2025
@AliceR
fix: Add wrapping div for scrollytelling map and chapters (#1437)
d764dba 
**Related Ticket:** Fix #1418

### Description of Changes
Since the legacy instance was using a lazyload-wrapper this wasn't
necessary*, but for instances not using this approach, the additional
wrapping div is actually required to build the layout as intended. It
doesn't hurt the legacy either.

\* The LazyLoad component from 'react-lazyload' creates a wrapping div
with `class="lazyload-wrapper "`


### Validation / Testing
Go to a story, make sure you can scroll down all the way to see text
content below the scrollymap, as well as map comparison blocks.
Corresponding deploy preview from next-veda-ui:
https://deploy-preview-43--veda-ui-next-test.netlify.app/stories/air-quality-and-covid-19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliceR AliceR

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Add wrapping div for scrollytelling map and chapters NASA-IMPACT/veda-ui
1 participant
@AliceR