-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve title resolution make it a background process #1214
Open
Kirandawadi
wants to merge
8
commits into
dev
Choose a base branch
from
1006-improve-title-resolution-make-it-a-background-process
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Improve title resolution make it a background process #1214
Kirandawadi
wants to merge
8
commits into
dev
from
1006-improve-title-resolution-make-it-a-background-process
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
Background_Title_Resolution.mov |
take a look at this: # if you want call apply by itsef apply()
# but if want to call it async, use apply_async()
def apply_async(self):
return self.apply.delay(self.id, *args, **kwargs)
@shared_task(bind=True)
def apply(self) -> None: |
Tests failing
def apply(self) -> None:
# Inserting here to avoid circular import issue
from ..tasks import process_title_resolutions
def queue_task():
process_title_resolutions.delay(self.id)
# Queue the background task only after the transaction commits (i.e, after apply() method)
transaction.on_commit(queue_task)
Methods Tried
@pytest.mark.django_db(transaction=True)
class TestDeltaTitlePattern(TransactionTestCase):
@pytest.mark.django_db(transaction=True)
def test_apply_generates_delta_url_if_title_differs(self):
# Call the `apply()` method and capture/execute `on_commit` callbacks
with self.captureOnCommitCallbacks(execute=True): # Ensure `on_commit` callbacks are executed
pattern.apply() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features Added