Tries to improve encoding handling in Extractor
#169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of immediately falling back to returning an unencoded string, we try to use utf-8 if we cannot accurately detect the content encoding. This is far from ideal, but since returning an unencoded string brings problems further down the pipeline (other workers are not able to decode it), this is a step to reduce this problems.
|
@fccoelho Did you get a chance to review this pull request? If it's OK, I want to merge it as soon as possible to work around the problem in production. |
|
@flavioamieiro, I think we should try other encodings before giving up. For example, 8859-1 , CP1252, etc. |
Since the rest of our workflow depends on the text being a unicode object, we need to make sure this is what we return from our decode process. If even after trying different codecs we cannot successfully decode the string, we will do it using utf-8 and replacing invalid chars with the unicode replacement character. I had to make two decisions here that could be changed further down the line: the encoding to use and the error handling. I decided on utf-8 because I think it is the most common encoding in our use cases and on `replace` instead of `ignore` so we would have some kind of evidence of where the invalid characters were (and that they existed in the first place).
|
This is a good idea but another possibility would be add something to the Exceptions property, but maybe that should be used strictly for failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of immediately falling back to returning an unencoded string, we try to
use utf-8 if we cannot accurately detect the content encoding.
This is far from ideal, but since returning an unencoded string brings problems
further down the pipeline (other workers are not able to decode it), this is a
step to reduce this problems.
@fccoelho can you please review and comment on this approach?