Minor improvements to parseGenericController()#13
Open
kevinmoran wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NotRange.Usageinstead ofRange.UsageMin. This wasn't a bug because these are overlapping members in a typed union, butvalueCaps[i].IsRangeis false for these inputs so this is the intended usage, think it's better for claritybuttonCapsarray - For the gamepads I tested all the buttons are always in thebuttonCaps[0]so I doubt this was ever hit, but it gave me some confusion in the debugger for my Dualsense controller which has a second buttonCapThanks!