Result fetch/#92 #95

yougyung · 2024-05-02T07:06:14Z

📌 작업 내용

구현 내용 및 작업 했던 내역

기존 getUserInfo가 회원 가입 등의 로직에 관련된 부분이 존재하는 것으로 보여 getUserInfo를 수정하지 않고 getResultUserInfo를 새롭게 생성했습니다.
Result page에 대한 data fetching작업을 진행했습니다.
다전공표기, 채플 학점 변환 작업 함께 진행했습니다.

🔊 도움이 필요한 부분

The merge-base changed after approval.

github-actions · 2024-05-02T10:39:38Z

🚀storybook: https://65ccb85d5afe55a024495bc0-wjhbwutjhy.chromatic.com/

gahyuun

고생하셨습니다

gahyuun · 2024-05-02T13:47:36Z

app/(sub-page)/result/page.tsx


 interface ResultPageProp {
  searchParams: { category: string };
 }

-function ResultPage({ searchParams }: ResultPageProp) {
+async function ResultPage({ searchParams }: ResultPageProp) {


async 키워드를 넣은 이유를 설명해주실 수 있나요?

기존 구조에서는 data fetching을 해당 컴포넌트에서 진행했는데, 구조 변경이 발생하면서 수정을 누락한 부분같습니다. 감사합니다. 02a1e0f

gahyuun · 2024-05-02T13:54:33Z

app/business/user/user.query.ts

+export async function fetchResultUserInfo(): Promise<ResultUserInfo> {
+  try {
+    const response = await fetch(API_PATH.resultUserInfo, {
+      headers: {
+        Authorization: `Bearer ${cookies().get('accessToken')?.value}`,
+      },
+    });
+
+    const result = await response.json();
+
+    httpErrorHandler(response, result);
+    return result;
+  } catch (error) {
+    throw error;
+  }
+}


회원가입 로직으로 인해 fetch Result userInfo를 만드셨다고 하셨는데, 혹시 이로 인해 어떤 문제가 있었는지 알려주실 수 있나요!?
저는 getUserInfo를 재사용했어서요..!

현재 mock data와 실제 backend에서 전송해주는 �type이 일치하지 않아(다전공 등의 사유로 변경되었습니다) UserInfo type을 변경해주는 과정이 필요했습니다. englishlevel studentID 등의 속성은 회원가입 과정에서 사용되는 속성이라는 생각이 들어서, type을 제가 임의로 변경하지 않고 새롭게 생성했습니다

gahyuun · 2024-05-02T13:56:27Z

app/ui/result/result-category-card/result-category-card.tsx

@@ -54,7 +66,7 @@ function ResultCategoryCard({ category, totalCredit, takenCredit }: ResultCatego
          <Image src={Book} width={24} height={24} alt="category-img" />
          <h3>{RESULT_CATEGORY_KO[category]}</h3>
        </div>
-        {filterSeveralMajor(category)}
+        {displaySeveralMajor(category)}


filter를 display로 변경해서 더 명확해진 것 같네요!

gahyuun · 2024-05-02T13:58:34Z

app/ui/result/result-category-card/result-category-card.tsx

+            <span className="font-bold">{takeCategoryCredit(category, totalCredit)}</span>
          </div>


이수 학점을 가져오기 위해 takenCategoryCredit이라는 네이밍을 사용하신 것 같은데 getCategoryCredit이나 caculateCategoryCredit 은 어떠신가요?!

개발을 진행할 당시에는 채플 category의 경우에만 *2를 통해 학점을 취득하므로 소유의 의미를 get보다 강하게 전달하기 위해서 take를 사용하였는데, 답변을 작성하면서 CategoryCredit자체가 category별 credit에 대한 의미를 포함하므로 get이 더 적절할 수 있겠다는 생각이 드네요. 의견 감사합니다. e795740

gahyuun · 2024-05-02T14:00:48Z

app/ui/user/user-info-card/user-info-card.tsx

user-info-card, user-info-naviagtor 의미가 모호할 수도 있지않나? 라는 생각이 드네요
어떤 이름이 좋을진 저도 딱 아이디어가 떠오르진 않지만 생각해보겠습니다!

gahyuun · 2024-05-02T14:05:32Z

app/ui/view/molecule/navigation-bar.tsx

@@ -4,7 +4,7 @@ import logo from '../../../../public/assets/logo.svg';
 export default function NavigationBar() {
  return (
    <div className="absolute p-4 border-b-[1px] w-full">
-      <Image className="md:h-10 h-7 w-[110px] md:w-[150px]" width={150} height={100} src={logo} alt="main-logo" />
+      {/* <Image className="md:h-10 h-7 w-[110px] md:w-[150px]" width={150} height={100} src={logo} alt="main-logo" /> */}


주석처리하신 이유가 있나요?

github-actions · 2024-05-03T02:17:06Z

🚀storybook: https://65ccb85d5afe55a024495bc0-ncmuasgxea.chromatic.com/

github-actions · 2024-05-03T02:21:58Z

🚀storybook: https://65ccb85d5afe55a024495bc0-mbtkkypczk.chromatic.com/

github-actions · 2024-05-03T02:29:43Z

🚀storybook: https://65ccb85d5afe55a024495bc0-okbqsvqsff.chromatic.com/

app/ui/user/user-info-card/user-info-card.tsx

seonghunYang · 2024-05-03T07:10:04Z

app/business/result/result.query.ts

+  major: string;
+}
+
+export interface ResultUserInfo {


이 부분 가현이 PR과 중복되는 것 같습니다. 두 분이 통합 계획이 있을까요?

기존에 Mock data로 활용되고 있는 user와 실제 응답받는 data의 차이로 인해 분리 및 통합하는 코드로 리팩토링을 진행할 예정입니다.
기존에는 동일 PR에 작업을 진행할 계획이었으나 보다 자세한 개발 과정에 대한 공유를 위해 별도의 PR로 분리해서 올리도록하겠습니다!

app/business/result/result.query.ts

github-actions · 2024-05-06T01:36:58Z

🚀storybook: https://65ccb85d5afe55a024495bc0-lgmahcyldb.chromatic.com/

github-actions · 2024-05-06T01:38:23Z

🚀storybook: https://65ccb85d5afe55a024495bc0-xolrkhtegy.chromatic.com/

github-actions · 2024-05-06T01:46:58Z

🚀storybook: https://65ccb85d5afe55a024495bc0-kvwxdeecvk.chromatic.com/

github-actions · 2024-05-06T01:48:33Z

🚀storybook: https://65ccb85d5afe55a024495bc0-kguphjmmkh.chromatic.com/

seonghunYang

수고 많았어요

yougyung added 10 commits May 1, 2024 11:56

feat: implement fetch result user info

a64aa6b

feat: implement fetch result category info

c2bf74a

feat: add getPercentage util

27c0dbf

fix: change naming fetch result user info

42a0e34

feat: add chaple option in category

05062a9

feat: add skeleton view in UserInfoCard

a2a6509

refactor: change structure in result page

93e1b47

feat: add skeleton view in resultCategory

81bfc3c

feat: add severalMajor option in resultUserCard

9c284e3

fix: remove conditional call in result dialog

aa1bb7e

yougyung self-assigned this May 2, 2024

yougyung requested review from seonghunYang and gahyuun as code owners May 2, 2024 07:06

fix: add authorization fetch result page

0661f2c

seonghunYang previously approved these changes May 2, 2024

View reviewed changes

chore: commit for merge

aa1d274

gahyuun reviewed May 2, 2024

View reviewed changes

chore: delete unused async keyword

02a1e0f

chore: fix the hidden logo to be exposed

9e3c7ff

fix: change getCategoryCredit naming

e795740

seonghunYang reviewed May 3, 2024

View reviewed changes

app/business/result/result.query.ts Show resolved Hide resolved

yougyung added 2 commits May 6, 2024 10:34

fix: change inline code style

b13ec94

fix: remove duplication type

05e3838

yougyung added 2 commits May 6, 2024 10:44

fix: add suffix response at server response type

511760c

chore: commit for merge

b46edb8

seonghunYang approved these changes May 7, 2024

View reviewed changes

gahyuun approved these changes May 7, 2024

View reviewed changes

yougyung merged commit 4c2c89a into main May 7, 2024
2 of 3 checks passed

yougyung deleted the result-fetch/#92 branch May 7, 2024 11:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Result fetch/#92 #95

Result fetch/#92 #95

yougyung commented May 2, 2024 •

edited

Loading

github-actions bot commented May 2, 2024

gahyuun left a comment

gahyuun May 2, 2024

yougyung May 3, 2024

gahyuun May 2, 2024

yougyung May 3, 2024

gahyuun May 2, 2024

gahyuun May 2, 2024

yougyung May 3, 2024

gahyuun May 2, 2024

gahyuun May 2, 2024

yougyung May 3, 2024

github-actions bot commented May 3, 2024

github-actions bot commented May 3, 2024

github-actions bot commented May 3, 2024

seonghunYang May 3, 2024

yougyung May 7, 2024

github-actions bot commented May 6, 2024

github-actions bot commented May 6, 2024

github-actions bot commented May 6, 2024

github-actions bot commented May 6, 2024

seonghunYang left a comment

		<span className="font-bold">{takeCategoryCredit(category, totalCredit)}</span>
		</div>

Result fetch/#92 #95

Result fetch/#92 #95

Conversation

yougyung commented May 2, 2024 • edited Loading

📌 작업 내용

🔊 도움이 필요한 부분

github-actions bot commented May 2, 2024

gahyuun left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented May 3, 2024

github-actions bot commented May 3, 2024

github-actions bot commented May 3, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented May 6, 2024

github-actions bot commented May 6, 2024

github-actions bot commented May 6, 2024

github-actions bot commented May 6, 2024

seonghunYang left a comment

Choose a reason for hiding this comment

yougyung commented May 2, 2024 •

edited

Loading